feat: add Document::page(int $n) to look up a page by number#12
Merged
pushpak1300 merged 2 commits intoJun 7, 2026
Merged
Conversation
Throws PageNotFoundException when the requested page number is absent, giving callers a typed exception instead of an array index error.
Extract the page scan into a private find() helper, add a non-throwing hasPage() companion to page(), and annotate page() with @throws.
b8815ec to
5b69793
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Document::page(int $number): Page— looks up a page by its 1-based page numberDocument::hasPage(int $number): bool— non-throwing existence check, so callers can probe without a try/catchPageNotFoundException(new, extendsParselException) when the number doesn't exist in the documentUndefined array keyerror from direct array accessfind()helper;page()is annotated with@throwsUsage
Test plan
Pageinstance for a valid page numberhasPage()returnstruefor an existing page andfalsefor a missing onePageNotFoundExceptionwith message"Page 99 was not found in the document."for missing page