ci: install liteparse and run integration tests in CI#13
Open
impruthvi wants to merge 2 commits into
Open
Conversation
Integration tests were silently skipped because the lit binary was never installed on CI runners. Add npm install step and a dedicated test:integration composer script so real-binary codepaths are verified on every push across all matrix runners.
Member
|
Tests failing. |
Contributor
Author
This will pass once PR #11 is merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Integration tests were never running in CI because the
litbinary was not installed on GitHub runners. The workflow only rancomposer test:unitwhich excludes theintegrationgroup — so real-binary codepaths (structured document parsing, lazy streaming) were never verified.This is how the camelCase DTO bug (#9) went undetected: unit tests pass against fixture JSON, but integration tests hit the actual binary output.
Changes
.github/workflows/tests.yml— addnpm install -g @llamaindex/liteparsestep and anIntegration Testsstep after unit testscomposer.json— addtest:integrationscript (pest --group=integration)Result
All 6 matrix runners (ubuntu/macos/windows × prefer-lowest/prefer-stable) now install
litand run integration tests on every push and pull request.Test plan
composer test:unitstill passes (unchanged)composer test:integrationruns the 3 integration tests against the real binary locally — all pass