Fix dangling pointers in preprocessor macro handling#20
Merged
Conversation
Reserve vector capacity before the loop to prevent reallocation from invalidating c_str() pointers stored in PreprocessorMacroDesc entries. Also fix the same issue in search path construction. Add preprocessor macro tests. Closes #19 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
The macos-15 runner no longer includes iOS Simulator runtimes with Xcode 16.2, causing destination lookup failures. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
The XCFramework only includes iOS libraries, so macOS destination cannot be used. Install the iOS platform to make the simulator available on macos-15 runners. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
The macos-15 runner no longer includes iOS Simulator runtimes for Xcode 16.2. Use Xcode 16.4 which has pre-installed runtimes available. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
std::vectorcapacity before the loop inSLGlobalSession.mmto preventpush_backreallocation from invalidatingc_str()pointers inPreprocessorMacroDescentriesCloses #19
Test plan
testMultiplePreprocessorMacros— 3 macros defined simultaneously (issue reproduction case)testPreprocessorMacroAffectsCompilation—#ifdefbranching verificationtestPreprocessorMacroWithValue— macro value expansion with array size🤖 Generated with Claude Code