From 03adb81e69e262992a1c4a9de8013ec0a0d9be5c Mon Sep 17 00:00:00 2001 From: Jean-Pierre Portier Date: Fri, 9 Jan 2026 17:12:31 +0100 Subject: [PATCH 1/2] feat: Rename some 'DEFAULT' const for Voice and Conversation --- MIGRATION-GUIDE.md | 14 ++++++++++++++ .../conversation/ConversationsSteps.java | 2 +- .../e2e/domains/conversation/EventsSteps.java | 2 +- .../sdk/e2e/domains/voice/v1/CallsSteps.java | 6 +++--- .../main/java/conversation/events/Send.java | 2 +- .../java/voice/calls/ManageWithCallLeg.java | 2 +- .../src/main/java/voice/calls/Update.java | 2 +- .../v1/events/types/ComposingEndEvent.java | 5 +++-- .../models/v1/events/types/ComposingEvent.java | 4 ++-- .../events/types/ConversationDeletedEvent.java | 7 +++---- .../messages/internal/AppMessageInternal.java | 7 +++---- .../internal/AppMessageInternalImpl.java | 18 ++++++++---------- .../v1/svaml/action/SvamlActionContinue.java | 2 +- .../v1/svaml/action/SvamlActionHangup.java | 2 +- .../instruction/SvamlInstructionAnswer.java | 2 +- .../SvamlInstructionStopRecording.java | 3 ++- .../request/SendEventRequestDtoTest.java | 2 +- .../events/types/ComposingEndEventDtoTest.java | 2 +- .../v1/events/types/ComposingEventDtoTest.java | 2 +- .../types/ConversationDeletedEventDtoTest.java | 3 ++- .../v1/callouts/CalloutRequestDtoTest.java | 2 +- .../svaml/action/SvamlActionContinueTest.java | 2 +- .../v1/svaml/action/SvamlActionHangupTest.java | 2 +- .../SvamlInstructionAnswerTest.java | 2 +- .../SvamlInstructionStopRecordingTest.java | 3 ++- 25 files changed, 57 insertions(+), 43 deletions(-) diff --git a/MIGRATION-GUIDE.md b/MIGRATION-GUIDE.md index 341fe0782..8cb941a04 100644 --- a/MIGRATION-GUIDE.md +++ b/MIGRATION-GUIDE.md @@ -13,6 +13,12 @@ This guide lists all removed classes and interfaces from V1 and how to migrate t - Conversation Template V1 is deprecated. Use Conversation Template V2 instead. #### Replacement models +| Old const | New const | +|--------------------------------|-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------| +| ComposingEndEvent.EMPTY | [ComposingEndEvent.COMPOSING_END_EVENT](https://www.javadoc.io/doc/com.sinch.sdk/sinch-sdk-java/2.0.0/com/sinch/sdk/domains/conversation/models/v1/events/types/ComposingEndEvent.html) | +| ComposingEvent.EMPTY | [ComposingEvent.COMPOSING_EVENT](https://www.javadoc.io/doc/com.sinch.sdk/sinch-sdk-java/2.0.0/com/sinch/sdk/domains/conversation/models/v1/events/types/ComposingEvent.html) | +| ConversationDeletedEvent.EMPTY | [ConversationDeletedEvent.CONVERSATION_DELETED_EVENT](https://www.javadoc.io/doc/com.sinch.sdk/sinch-sdk-java/2.0.0/com/sinch/sdk/domains/conversation/models/v1/events/types/ComposingEvent.html) | + | Old class | New class | |--------------------------------------------------|-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------| | models.v1.messages.types.card.CardMessageMedia | [com.sinch.sdk.domains.conversation.models.v1.messages.types.media.MediaMessage](https://www.javadoc.io/doc/com.sinch.sdk/sinch-sdk-java/2.0.0/com/sinch/sdk/domains/conversation/models/v1/messages/types/media/MediaMessage.html) | @@ -189,6 +195,14 @@ Use the new versioned API under `sms().v1()` to get access to [SMSService](https #### Replacement models +| Old const | New const | +|---------------------------------------|-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------| +| SvamlActionContinue.DEFAULT | [SvamlActionContinue.SVAML_ACTION_CONTINUE](https://www.javadoc.io/doc/com.sinch.sdk/sinch-sdk-java/2.0.0/com/sinch/sdk/domains/voice/models/v1/svaml/action/SvamlActionContinue.html) | +| SvamlActionHangup.DEFAULT | [SvamlActionHangup.SVAML_ACTION_HANGUP](https://www.javadoc.io/doc/com.sinch.sdk/sinch-sdk-java/2.0.0/com/sinch/sdk/domains/voice/models/v1/svaml/action/SvamlActionHangup.html) | +| SvamlInstructionAnswer.DEFAULT | [SvamlInstructionAnswer.SVAML_INSTRUCTION_ANSWER](https://www.javadoc.io/doc/com.sinch.sdk/sinch-sdk-java/2.0.0/com/sinch/sdk/domains/voice/models/v1/svaml/action/SvamlInstructionAnswer.html) | +| SvamlInstructionStopRecording.DEFAULT | [SvamlInstructionStopRecording.SVAML_INSTRUCTION_STOP_RECORDING](https://www.javadoc.io/doc/com.sinch.sdk/sinch-sdk-java/2.0.0/com/sinch/sdk/domains/voice/models/v1/svaml/action/SvamlInstructionStopRecording.html) | + + ##### Destination | Old class | New class | |------------------------------|----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------| diff --git a/client/src/test/java/com/sinch/sdk/e2e/domains/conversation/ConversationsSteps.java b/client/src/test/java/com/sinch/sdk/e2e/domains/conversation/ConversationsSteps.java index 3b4104462..915ae9b15 100644 --- a/client/src/test/java/com/sinch/sdk/e2e/domains/conversation/ConversationsSteps.java +++ b/client/src/test/java/com/sinch/sdk/e2e/domains/conversation/ConversationsSteps.java @@ -150,7 +150,7 @@ public void delete() { public void injectEvent() { InjectEventRequest request = InjectEventRequest.builder() - .setAppEvent(ComposingEvent.EMPTY) + .setAppEvent(ComposingEvent.COMPOSING_EVENT) .setAcceptTime(Instant.now()) .build(); injectEventResponse = service.injectEvent(CONVERSATION_ID, request); diff --git a/client/src/test/java/com/sinch/sdk/e2e/domains/conversation/EventsSteps.java b/client/src/test/java/com/sinch/sdk/e2e/domains/conversation/EventsSteps.java index 7fa35118a..e7da7ce0c 100644 --- a/client/src/test/java/com/sinch/sdk/e2e/domains/conversation/EventsSteps.java +++ b/client/src/test/java/com/sinch/sdk/e2e/domains/conversation/EventsSteps.java @@ -38,7 +38,7 @@ public void send() { SendEventRequest.builder() .setAppId(AppsSteps.APP_ID) .setRecipient(ContactId.builder().setContactId(ContactsSteps.CONTACT_ID).build()) - .setEvent(ComposingEvent.EMPTY) + .setEvent(ComposingEvent.COMPOSING_EVENT) .build(); sendResponse = service.send(request); diff --git a/client/src/test/java/com/sinch/sdk/e2e/domains/voice/v1/CallsSteps.java b/client/src/test/java/com/sinch/sdk/e2e/domains/voice/v1/CallsSteps.java index 26a5ef5e1..6e32a5dbf 100644 --- a/client/src/test/java/com/sinch/sdk/e2e/domains/voice/v1/CallsSteps.java +++ b/client/src/test/java/com/sinch/sdk/e2e/domains/voice/v1/CallsSteps.java @@ -54,7 +54,7 @@ public void updateCall() { .setText("Sorry, the conference has been cancelled. The call will end now.") .setLocale("en-US") .build())) - .setAction(SvamlActionHangup.DEFAULT) + .setAction(SvamlActionHangup.SVAML_ACTION_HANGUP) .build(); service.update("1ce0ffee-ca11-ca11-ca11-abcdef000022", request); updatePassed = true; @@ -71,7 +71,7 @@ public void updateCallNotExits() { .setText("Sorry, the conference has been cancelled. The call will end now.") .setLocale("en-US") .build())) - .setAction(SvamlActionHangup.DEFAULT) + .setAction(SvamlActionHangup.SVAML_ACTION_HANGUP) .build(); try { service.update("not-existing-callId", request); @@ -92,7 +92,7 @@ public void manageCallWithCallLeg() { Arrays.asList( "https://samples-files.com/samples/Audio/mp3/sample-file-4.mp3")) .build())) - .setAction(SvamlActionContinue.DEFAULT) + .setAction(SvamlActionContinue.SVAML_ACTION_CONTINUE) .build(); service.manageWithCallLeg("1ce0ffee-ca11-ca11-ca11-abcdef000022", CallLeg.CALLEE, request); manageWithCallLegPassed = true; diff --git a/examples/snippets/src/main/java/conversation/events/Send.java b/examples/snippets/src/main/java/conversation/events/Send.java index 84c1f8ed1..0d74a503c 100644 --- a/examples/snippets/src/main/java/conversation/events/Send.java +++ b/examples/snippets/src/main/java/conversation/events/Send.java @@ -51,7 +51,7 @@ public static void main(String[] args) { EventsService eventsService = client.conversation().v1().events(); - AppEvent event = ComposingEndEvent.EMPTY; + AppEvent event = ComposingEndEvent.COMPOSING_END_EVENT; SendEventRequest request = SendEventRequest.builder() diff --git a/examples/snippets/src/main/java/voice/calls/ManageWithCallLeg.java b/examples/snippets/src/main/java/voice/calls/ManageWithCallLeg.java index 65718837e..47c74a033 100644 --- a/examples/snippets/src/main/java/voice/calls/ManageWithCallLeg.java +++ b/examples/snippets/src/main/java/voice/calls/ManageWithCallLeg.java @@ -47,7 +47,7 @@ public static void main(String[] args) { LOGGER.info(String.format("Manage call with ID '%s'", callId)); - SvamlAction action = SvamlActionHangup.DEFAULT; + SvamlAction action = SvamlActionHangup.SVAML_ACTION_HANGUP; Collection instructions = Collections.singletonList( diff --git a/examples/snippets/src/main/java/voice/calls/Update.java b/examples/snippets/src/main/java/voice/calls/Update.java index 1cfe82802..9d5cbad45 100644 --- a/examples/snippets/src/main/java/voice/calls/Update.java +++ b/examples/snippets/src/main/java/voice/calls/Update.java @@ -34,7 +34,7 @@ public static void main(String[] args) { // The instruction to be performed SvamlInstruction instruction = SvamlInstructionSay.builder().setText("Goodbye").build(); // The instruction to add to the call - SvamlAction action = SvamlActionHangup.DEFAULT; + SvamlAction action = SvamlActionHangup.SVAML_ACTION_HANGUP; Configuration configuration = Configuration.builder() diff --git a/openapi-contracts/src/main/com/sinch/sdk/domains/conversation/models/v1/events/types/ComposingEndEvent.java b/openapi-contracts/src/main/com/sinch/sdk/domains/conversation/models/v1/events/types/ComposingEndEvent.java index 8433fce5b..89c8374ee 100644 --- a/openapi-contracts/src/main/com/sinch/sdk/domains/conversation/models/v1/events/types/ComposingEndEvent.java +++ b/openapi-contracts/src/main/com/sinch/sdk/domains/conversation/models/v1/events/types/ComposingEndEvent.java @@ -11,6 +11,7 @@ package com.sinch.sdk.domains.conversation.models.v1.events.types; import com.fasterxml.jackson.databind.annotation.JsonDeserialize; +import com.sinch.sdk.core.models.OptionalValue; import java.util.Collections; /** Composing End Event Type */ @@ -20,8 +21,8 @@ public interface ComposingEndEvent com.sinch.sdk.domains.conversation.models.v1.events.AppEvent { /** Default EMPTY message to be used to send a ComposingEndEvent */ - ComposingEndEvent EMPTY = - new ComposingEndEventImpl.Builder().setComposingEndEvent(Collections.EMPTY_MAP).build(); + ComposingEndEvent COMPOSING_END_EVENT = + new ComposingEndEventImpl(OptionalValue.of(Collections.emptyMap())); /** * Getting builder diff --git a/openapi-contracts/src/main/com/sinch/sdk/domains/conversation/models/v1/events/types/ComposingEvent.java b/openapi-contracts/src/main/com/sinch/sdk/domains/conversation/models/v1/events/types/ComposingEvent.java index bfe96b294..f3834912c 100644 --- a/openapi-contracts/src/main/com/sinch/sdk/domains/conversation/models/v1/events/types/ComposingEvent.java +++ b/openapi-contracts/src/main/com/sinch/sdk/domains/conversation/models/v1/events/types/ComposingEvent.java @@ -11,6 +11,7 @@ package com.sinch.sdk.domains.conversation.models.v1.events.types; import com.fasterxml.jackson.databind.annotation.JsonDeserialize; +import com.sinch.sdk.core.models.OptionalValue; import java.util.Collections; /** Composing */ @@ -20,8 +21,7 @@ public interface ComposingEvent com.sinch.sdk.domains.conversation.models.v1.events.ContactEvent { /** Default EMPTY message to be used to send a ComposingEvent */ - ComposingEvent EMPTY = - new ComposingEventImpl.Builder().setComposingEvent(Collections.EMPTY_MAP).build(); + ComposingEvent COMPOSING_EVENT = new ComposingEventImpl(OptionalValue.of(Collections.emptyMap())); /** * Getting builder diff --git a/openapi-contracts/src/main/com/sinch/sdk/domains/conversation/models/v1/events/types/ConversationDeletedEvent.java b/openapi-contracts/src/main/com/sinch/sdk/domains/conversation/models/v1/events/types/ConversationDeletedEvent.java index 7d9a69b8e..5f031cecd 100644 --- a/openapi-contracts/src/main/com/sinch/sdk/domains/conversation/models/v1/events/types/ConversationDeletedEvent.java +++ b/openapi-contracts/src/main/com/sinch/sdk/domains/conversation/models/v1/events/types/ConversationDeletedEvent.java @@ -11,6 +11,7 @@ package com.sinch.sdk.domains.conversation.models.v1.events.types; import com.fasterxml.jackson.databind.annotation.JsonDeserialize; +import com.sinch.sdk.core.models.OptionalValue; import java.util.Collections; /** Conversation Deleted Event Type */ @@ -19,10 +20,8 @@ public interface ConversationDeletedEvent extends com.sinch.sdk.domains.conversation.models.v1.events.ContactEvent { /** Default EMPTY message to be used to send a ConversationDeletedEvent */ - ConversationDeletedEvent EMPTY = - new ConversationDeletedEventImpl.Builder() - .setConversationDeletedEvent(Collections.EMPTY_MAP) - .build(); + ConversationDeletedEvent CONVERSATION_DELETED_EVENT = + new ConversationDeletedEventImpl(OptionalValue.of(Collections.emptyMap())); /** * Getting builder diff --git a/openapi-contracts/src/main/com/sinch/sdk/domains/conversation/models/v1/messages/internal/AppMessageInternal.java b/openapi-contracts/src/main/com/sinch/sdk/domains/conversation/models/v1/messages/internal/AppMessageInternal.java index 0c3162365..0338faefc 100644 --- a/openapi-contracts/src/main/com/sinch/sdk/domains/conversation/models/v1/messages/internal/AppMessageInternal.java +++ b/openapi-contracts/src/main/com/sinch/sdk/domains/conversation/models/v1/messages/internal/AppMessageInternal.java @@ -14,6 +14,7 @@ import com.sinch.sdk.domains.conversation.models.v1.Agent; import com.sinch.sdk.domains.conversation.models.v1.ConversationChannel; import com.sinch.sdk.domains.conversation.models.v1.messages.OmniMessageOverride; +import com.sinch.sdk.domains.conversation.models.v1.messages.OmniMessageOverride.ChannelSpecificTemplate; import com.sinch.sdk.domains.conversation.models.v1.messages.types.card.CardMessage; import com.sinch.sdk.domains.conversation.models.v1.messages.types.carousel.CarouselMessage; import com.sinch.sdk.domains.conversation.models.v1.messages.types.channelspecific.ChannelSpecificMessage; @@ -117,8 +118,7 @@ public interface AppMessageInternal { * * @return explicitChannelOmniMessage */ - Map - getExplicitChannelOmniMessage(); + Map getExplicitChannelOmniMessage(); /** * Channel specific messages, overriding any transcoding. The structure of this property is more @@ -247,8 +247,7 @@ interface Builder { * @see #getExplicitChannelOmniMessage */ Builder setExplicitChannelOmniMessage( - Map - explicitChannelOmniMessage); + Map explicitChannelOmniMessage); /** * see getter diff --git a/openapi-contracts/src/main/com/sinch/sdk/domains/conversation/models/v1/messages/internal/AppMessageInternalImpl.java b/openapi-contracts/src/main/com/sinch/sdk/domains/conversation/models/v1/messages/internal/AppMessageInternalImpl.java index a556d1279..f3070efcb 100644 --- a/openapi-contracts/src/main/com/sinch/sdk/domains/conversation/models/v1/messages/internal/AppMessageInternalImpl.java +++ b/openapi-contracts/src/main/com/sinch/sdk/domains/conversation/models/v1/messages/internal/AppMessageInternalImpl.java @@ -10,6 +10,7 @@ import com.sinch.sdk.domains.conversation.models.v1.Agent; import com.sinch.sdk.domains.conversation.models.v1.ConversationChannel; import com.sinch.sdk.domains.conversation.models.v1.messages.OmniMessageOverride; +import com.sinch.sdk.domains.conversation.models.v1.messages.OmniMessageOverride.ChannelSpecificTemplate; import com.sinch.sdk.domains.conversation.models.v1.messages.types.card.CardMessage; import com.sinch.sdk.domains.conversation.models.v1.messages.types.carousel.CarouselMessage; import com.sinch.sdk.domains.conversation.models.v1.messages.types.channelspecific.ChannelSpecificMessage; @@ -86,7 +87,7 @@ public class AppMessageInternalImpl implements AppMessageInternal { public static final String JSON_PROPERTY_EXPLICIT_CHANNEL_OMNI_MESSAGE = "explicit_channel_omni_message"; - private OptionalValue> + private OptionalValue> explicitChannelOmniMessage; public static final String JSON_PROPERTY_CHANNEL_SPECIFIC_MESSAGE = "channel_specific_message"; @@ -110,8 +111,7 @@ protected AppMessageInternalImpl( OptionalValue listMessage, OptionalValue contactInfoMessage, OptionalValue> explicitChannelMessage, - OptionalValue> - explicitChannelOmniMessage, + OptionalValue> explicitChannelOmniMessage, OptionalValue> channelSpecificMessage, OptionalValue agent) { this.cardMessage = cardMessage; @@ -240,14 +240,13 @@ public OptionalValue> explicitChannelMessage() } @JsonIgnore - public Map - getExplicitChannelOmniMessage() { + public Map getExplicitChannelOmniMessage() { return explicitChannelOmniMessage.orElse(null); } @JsonProperty(JSON_PROPERTY_EXPLICIT_CHANNEL_OMNI_MESSAGE) @JsonInclude(value = JsonInclude.Include.USE_DEFAULTS) - public OptionalValue> + public OptionalValue> explicitChannelOmniMessage() { return explicitChannelOmniMessage; } @@ -366,8 +365,8 @@ static class Builder implements AppMessageInternal.Builder { OptionalValue listMessage = OptionalValue.empty(); OptionalValue contactInfoMessage = OptionalValue.empty(); OptionalValue> explicitChannelMessage = OptionalValue.empty(); - OptionalValue> - explicitChannelOmniMessage = OptionalValue.empty(); + OptionalValue> explicitChannelOmniMessage = + OptionalValue.empty(); OptionalValue> channelSpecificMessage = OptionalValue.empty(); OptionalValue agent = OptionalValue.empty(); @@ -435,8 +434,7 @@ public Builder setExplicitChannelMessage( @JsonProperty(JSON_PROPERTY_EXPLICIT_CHANNEL_OMNI_MESSAGE) public Builder setExplicitChannelOmniMessage( - Map - explicitChannelOmniMessage) { + Map explicitChannelOmniMessage) { this.explicitChannelOmniMessage = OptionalValue.of(explicitChannelOmniMessage); return this; } diff --git a/openapi-contracts/src/main/com/sinch/sdk/domains/voice/models/v1/svaml/action/SvamlActionContinue.java b/openapi-contracts/src/main/com/sinch/sdk/domains/voice/models/v1/svaml/action/SvamlActionContinue.java index 50c96c655..37240e504 100644 --- a/openapi-contracts/src/main/com/sinch/sdk/domains/voice/models/v1/svaml/action/SvamlActionContinue.java +++ b/openapi-contracts/src/main/com/sinch/sdk/domains/voice/models/v1/svaml/action/SvamlActionContinue.java @@ -26,7 +26,7 @@ public interface SvamlActionContinue extends com.sinch.sdk.domains.voice.models.v1.svaml.action.SvamlAction { /** ready to use action to send a `continue` */ - SvamlActionContinue DEFAULT = SvamlActionContinue.builder().build(); + SvamlActionContinue SVAML_ACTION_CONTINUE = SvamlActionContinue.builder().build(); /** The name property. Must have the value continue. */ public class NameEnum extends EnumDynamic { diff --git a/openapi-contracts/src/main/com/sinch/sdk/domains/voice/models/v1/svaml/action/SvamlActionHangup.java b/openapi-contracts/src/main/com/sinch/sdk/domains/voice/models/v1/svaml/action/SvamlActionHangup.java index c979420ec..c40d66663 100644 --- a/openapi-contracts/src/main/com/sinch/sdk/domains/voice/models/v1/svaml/action/SvamlActionHangup.java +++ b/openapi-contracts/src/main/com/sinch/sdk/domains/voice/models/v1/svaml/action/SvamlActionHangup.java @@ -28,7 +28,7 @@ public interface SvamlActionHangup extends com.sinch.sdk.domains.voice.models.v1.svaml.action.SvamlAction { /** ready to use action to send a `hangup` */ - SvamlActionHangup DEFAULT = SvamlActionHangup.builder().build(); + SvamlActionHangup SVAML_ACTION_HANGUP = SvamlActionHangup.builder().build(); /** The name property. Must have the value hangup. */ public class NameEnum extends EnumDynamic { diff --git a/openapi-contracts/src/main/com/sinch/sdk/domains/voice/models/v1/svaml/instruction/SvamlInstructionAnswer.java b/openapi-contracts/src/main/com/sinch/sdk/domains/voice/models/v1/svaml/instruction/SvamlInstructionAnswer.java index 1f521f577..cbd97d136 100644 --- a/openapi-contracts/src/main/com/sinch/sdk/domains/voice/models/v1/svaml/instruction/SvamlInstructionAnswer.java +++ b/openapi-contracts/src/main/com/sinch/sdk/domains/voice/models/v1/svaml/instruction/SvamlInstructionAnswer.java @@ -22,7 +22,7 @@ public interface SvamlInstructionAnswer extends com.sinch.sdk.domains.voice.models.v1.svaml.instruction.SvamlInstruction { /** ready to use instruction to send a `answer` */ - SvamlInstructionAnswer DEFAULT = SvamlInstructionAnswer.builder().build(); + SvamlInstructionAnswer SVAML_INSTRUCTION_ANSWER = SvamlInstructionAnswer.builder().build(); /** The name property. Must have the value answer. */ public class NameEnum extends EnumDynamic { diff --git a/openapi-contracts/src/main/com/sinch/sdk/domains/voice/models/v1/svaml/instruction/SvamlInstructionStopRecording.java b/openapi-contracts/src/main/com/sinch/sdk/domains/voice/models/v1/svaml/instruction/SvamlInstructionStopRecording.java index ec7807e7a..33f328d43 100644 --- a/openapi-contracts/src/main/com/sinch/sdk/domains/voice/models/v1/svaml/instruction/SvamlInstructionStopRecording.java +++ b/openapi-contracts/src/main/com/sinch/sdk/domains/voice/models/v1/svaml/instruction/SvamlInstructionStopRecording.java @@ -22,7 +22,8 @@ public interface SvamlInstructionStopRecording extends com.sinch.sdk.domains.voice.models.v1.svaml.instruction.SvamlInstruction { /** ready to use instruction to send a `stop recording` */ - SvamlInstructionStopRecording DEFAULT = SvamlInstructionStopRecording.builder().build(); + SvamlInstructionStopRecording SVAML_INSTRUCTION_STOP_RECORDING = + SvamlInstructionStopRecording.builder().build(); /** The name property. Must have the value stopRecording. */ public class NameEnum extends EnumDynamic { diff --git a/openapi-contracts/src/test/java/com/sinch/sdk/domains/conversation/models/v1/events/request/SendEventRequestDtoTest.java b/openapi-contracts/src/test/java/com/sinch/sdk/domains/conversation/models/v1/events/request/SendEventRequestDtoTest.java index 51bf4ddaa..25102e098 100644 --- a/openapi-contracts/src/test/java/com/sinch/sdk/domains/conversation/models/v1/events/request/SendEventRequestDtoTest.java +++ b/openapi-contracts/src/test/java/com/sinch/sdk/domains/conversation/models/v1/events/request/SendEventRequestDtoTest.java @@ -20,7 +20,7 @@ public class SendEventRequestDtoTest extends ConversationBaseTest { public static SendEventRequest sendEventDto = SendEventRequest.builder() .setAppId("an app id") - .setEvent(ComposingEndEvent.EMPTY) + .setEvent(ComposingEndEvent.COMPOSING_END_EVENT) .setRecipient( ChannelRecipientIdentities.of( ChannelRecipientIdentity.builder() diff --git a/openapi-contracts/src/test/java/com/sinch/sdk/domains/conversation/models/v1/events/types/ComposingEndEventDtoTest.java b/openapi-contracts/src/test/java/com/sinch/sdk/domains/conversation/models/v1/events/types/ComposingEndEventDtoTest.java index 2e2928aab..4c2463147 100644 --- a/openapi-contracts/src/test/java/com/sinch/sdk/domains/conversation/models/v1/events/types/ComposingEndEventDtoTest.java +++ b/openapi-contracts/src/test/java/com/sinch/sdk/domains/conversation/models/v1/events/types/ComposingEndEventDtoTest.java @@ -19,7 +19,7 @@ public class ComposingEndEventDtoTest extends ConversationBaseTest { @GivenTextResource("domains/conversation/v1/events/types/ComposingEndEventDto.json") String json; - public static ComposingEndEvent expectedDto = ComposingEndEvent.EMPTY; + public static ComposingEndEvent expectedDto = ComposingEndEvent.COMPOSING_END_EVENT; @Test void serialize() throws JsonProcessingException, JSONException { diff --git a/openapi-contracts/src/test/java/com/sinch/sdk/domains/conversation/models/v1/events/types/ComposingEventDtoTest.java b/openapi-contracts/src/test/java/com/sinch/sdk/domains/conversation/models/v1/events/types/ComposingEventDtoTest.java index 6db597cf4..44eda7c6f 100644 --- a/openapi-contracts/src/test/java/com/sinch/sdk/domains/conversation/models/v1/events/types/ComposingEventDtoTest.java +++ b/openapi-contracts/src/test/java/com/sinch/sdk/domains/conversation/models/v1/events/types/ComposingEventDtoTest.java @@ -19,7 +19,7 @@ public class ComposingEventDtoTest extends ConversationBaseTest { @GivenTextResource("domains/conversation/v1/events/types/ComposingEventDto.json") String json; - public static ComposingEvent expectedDto = ComposingEvent.EMPTY; + public static ComposingEvent expectedDto = ComposingEvent.COMPOSING_EVENT; @Test void serialize() throws JsonProcessingException, JSONException { diff --git a/openapi-contracts/src/test/java/com/sinch/sdk/domains/conversation/models/v1/events/types/ConversationDeletedEventDtoTest.java b/openapi-contracts/src/test/java/com/sinch/sdk/domains/conversation/models/v1/events/types/ConversationDeletedEventDtoTest.java index f3da8c8e4..1ab4c312a 100644 --- a/openapi-contracts/src/test/java/com/sinch/sdk/domains/conversation/models/v1/events/types/ConversationDeletedEventDtoTest.java +++ b/openapi-contracts/src/test/java/com/sinch/sdk/domains/conversation/models/v1/events/types/ConversationDeletedEventDtoTest.java @@ -19,7 +19,8 @@ public class ConversationDeletedEventDtoTest extends ConversationBaseTest { @GivenTextResource("domains/conversation/v1/events/types/ConversationDeletedEventDto.json") String json; - public static ConversationDeletedEvent expectedDto = ConversationDeletedEvent.EMPTY; + public static ConversationDeletedEvent expectedDto = + ConversationDeletedEvent.CONVERSATION_DELETED_EVENT; @Test void serialize() throws JsonProcessingException, JSONException { diff --git a/openapi-contracts/src/test/java/com/sinch/sdk/domains/voice/models/v1/callouts/CalloutRequestDtoTest.java b/openapi-contracts/src/test/java/com/sinch/sdk/domains/voice/models/v1/callouts/CalloutRequestDtoTest.java index d10ba10a6..92dcbc781 100644 --- a/openapi-contracts/src/test/java/com/sinch/sdk/domains/voice/models/v1/callouts/CalloutRequestDtoTest.java +++ b/openapi-contracts/src/test/java/com/sinch/sdk/domains/voice/models/v1/callouts/CalloutRequestDtoTest.java @@ -101,7 +101,7 @@ public class CalloutRequestDtoTest extends VoiceBaseTest { SvamlInstructionSay.builder() .setText("Hello, this is a call from Sinch!") .build())) - .setAction(SvamlActionHangup.DEFAULT) + .setAction(SvamlActionHangup.SVAML_ACTION_HANGUP) .build()) .setPie(ControlUrl.from("https://your-application-server-host/application")) .build(); diff --git a/openapi-contracts/src/test/java/com/sinch/sdk/domains/voice/models/v1/svaml/action/SvamlActionContinueTest.java b/openapi-contracts/src/test/java/com/sinch/sdk/domains/voice/models/v1/svaml/action/SvamlActionContinueTest.java index 5a584366b..d2f8ffb40 100644 --- a/openapi-contracts/src/test/java/com/sinch/sdk/domains/voice/models/v1/svaml/action/SvamlActionContinueTest.java +++ b/openapi-contracts/src/test/java/com/sinch/sdk/domains/voice/models/v1/svaml/action/SvamlActionContinueTest.java @@ -11,7 +11,7 @@ @TestWithResources public class SvamlActionContinueTest extends BaseTest { - public static SvamlActionContinue dto = SvamlActionContinue.DEFAULT; + public static SvamlActionContinue dto = SvamlActionContinue.SVAML_ACTION_CONTINUE; @GivenTextResource("/domains/voice/v1/svaml/action/SvamlActionContinueDto.json") String json; diff --git a/openapi-contracts/src/test/java/com/sinch/sdk/domains/voice/models/v1/svaml/action/SvamlActionHangupTest.java b/openapi-contracts/src/test/java/com/sinch/sdk/domains/voice/models/v1/svaml/action/SvamlActionHangupTest.java index f9fa51857..c91e44e26 100644 --- a/openapi-contracts/src/test/java/com/sinch/sdk/domains/voice/models/v1/svaml/action/SvamlActionHangupTest.java +++ b/openapi-contracts/src/test/java/com/sinch/sdk/domains/voice/models/v1/svaml/action/SvamlActionHangupTest.java @@ -11,7 +11,7 @@ @TestWithResources public class SvamlActionHangupTest extends BaseTest { - public static SvamlActionHangup dto = SvamlActionHangup.DEFAULT; + public static SvamlActionHangup dto = SvamlActionHangup.SVAML_ACTION_HANGUP; @GivenTextResource("/domains/voice/v1/svaml/action/SvamlActionHangupDto.json") String json; diff --git a/openapi-contracts/src/test/java/com/sinch/sdk/domains/voice/models/v1/svaml/instruction/SvamlInstructionAnswerTest.java b/openapi-contracts/src/test/java/com/sinch/sdk/domains/voice/models/v1/svaml/instruction/SvamlInstructionAnswerTest.java index b734e16c7..bc3e6760c 100644 --- a/openapi-contracts/src/test/java/com/sinch/sdk/domains/voice/models/v1/svaml/instruction/SvamlInstructionAnswerTest.java +++ b/openapi-contracts/src/test/java/com/sinch/sdk/domains/voice/models/v1/svaml/instruction/SvamlInstructionAnswerTest.java @@ -11,7 +11,7 @@ @TestWithResources public class SvamlInstructionAnswerTest extends BaseTest { - public static SvamlInstructionAnswer dto = SvamlInstructionAnswer.DEFAULT; + public static SvamlInstructionAnswer dto = SvamlInstructionAnswer.SVAML_INSTRUCTION_ANSWER; @GivenTextResource("/domains/voice/v1/svaml/instruction/SvamlInstructionAnswerDto.json") String json; diff --git a/openapi-contracts/src/test/java/com/sinch/sdk/domains/voice/models/v1/svaml/instruction/SvamlInstructionStopRecordingTest.java b/openapi-contracts/src/test/java/com/sinch/sdk/domains/voice/models/v1/svaml/instruction/SvamlInstructionStopRecordingTest.java index 73869398b..54f4726fb 100644 --- a/openapi-contracts/src/test/java/com/sinch/sdk/domains/voice/models/v1/svaml/instruction/SvamlInstructionStopRecordingTest.java +++ b/openapi-contracts/src/test/java/com/sinch/sdk/domains/voice/models/v1/svaml/instruction/SvamlInstructionStopRecordingTest.java @@ -11,7 +11,8 @@ @TestWithResources public class SvamlInstructionStopRecordingTest extends BaseTest { - public static SvamlInstructionStopRecording dto = SvamlInstructionStopRecording.DEFAULT; + public static SvamlInstructionStopRecording dto = + SvamlInstructionStopRecording.SVAML_INSTRUCTION_STOP_RECORDING; @GivenTextResource("/domains/voice/v1/svaml/instruction/SvamlInstructionStopRecordingDto.json") String json; From a7a28d3879e519cbbc828d91b9ffa0e471fbbfa8 Mon Sep 17 00:00:00 2001 From: Jean-Pierre Portier Date: Wed, 14 Jan 2026 17:00:29 +0100 Subject: [PATCH 2/2] doc (SMS/Group): Description comments update --- .../sms/models/v1/groups/request/GroupUpdateRequest.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/openapi-contracts/src/main/com/sinch/sdk/domains/sms/models/v1/groups/request/GroupUpdateRequest.java b/openapi-contracts/src/main/com/sinch/sdk/domains/sms/models/v1/groups/request/GroupUpdateRequest.java index 2aaea8910..d7433ff00 100644 --- a/openapi-contracts/src/main/com/sinch/sdk/domains/sms/models/v1/groups/request/GroupUpdateRequest.java +++ b/openapi-contracts/src/main/com/sinch/sdk/domains/sms/models/v1/groups/request/GroupUpdateRequest.java @@ -45,14 +45,14 @@ public interface GroupUpdateRequest { String getName(); /** - * One time copy of all members from the group referenced by the group ID into this group. + * Copy the members from the another group into this group. Constraints: Must be valid group ID * * @return addFromGroup */ String getAddFromGroup(); /** - * Remove all members from this group that are currently in the group referenced by the group ID. + * Remove the members in a specified group from this group. Constraints: Must be valid group ID * * @return removeFromGroup */