Skip to content

Conflicts happen if two projects use the same local package #196

@petersg83

Description

@petersg83

Hello :)

context
I would like to use update-notifier in https://github.com/strapi/strapi in order to ask users of strapi to update their local package.

Issue
In the case the user has 2 strapi projects, they share the same configStore file: ~/.config/configstore/update-notifier-strapi.json and that may lead to incorrect behavior concerning the variable lastUpdateCheck (and update I think).

lastUpdateCheck is updated by both projects and only one of them will be notified when a new version is out.
If one project is used way more often than the other, it would be quite the only one to have the notifications.
The more strapi projects the user has, the more the problem is visible.

Code

  const notifier = updateNotifier({
    pkg,
    updateCheckInterval: 1000 * 60 * 60 * 24 * 7, // 1 week
    shouldNotifyInNpmScript: true,
  });

  const currentVersionLog = chalk.dim('{currentVersion}');
  const newVersionLog = chalk.green('{latestVersion}');
  const releaseLink = chalk.bold('https://github.com/strapi/strapi/releases');
  let message = `
  A new version of Strapi is available ${currentVersionLog}${newVersionLog}
  Check out new releases at: ${releaseLink}
  `;

  notifier.notify({ defer: false, message: message.trim() });

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions