Skip to content
This repository was archived by the owner on Jul 5, 2022. It is now read-only.
This repository was archived by the owner on Jul 5, 2022. It is now read-only.

[Bug]: ZSH shell on linux deploy scripts not working #19

Description

@shankars99

Describe the bug

So there's 3 different bugs that I'm facing

What I did is run the script and also echo out the command from the deploy script

  1. No constructor
    Contract isn't deploying as it expects --constructor-args
    forge create ./src/${Test}.sol:${Test} -i --rpc-url $rpc --constructor-args

  2. Constructor present 1 parameter
    This works perfectly
    forge create ./src/${Test}.sol:${Test} -i --rpc-url $rpc --constructor-args 10

  3. Constructor present >1 parameters
    Only the first parameter gets passed
    forge create ./src/${Test}.sol:${Test} -i --rpc-url $rpc --constructor-args 10

To Reproduce

in the describe the bug

Expected behavior

Deployed contracts

Additional context

I think it could be due to
read -ra args

and adding a length check for args to differentiate error case 1 from 2 and 3

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workingtriageIssue not analysed yet

    Type

    No type

    Fields

    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions