Skip to content

Commit 31f97d7

Browse files
committed
feat: Update package version to "8.4.606" and enhance macOS build scripts
1 parent e9dfeed commit 31f97d7

3 files changed

Lines changed: 22 additions & 9 deletions

File tree

.github/scripts/import_macos_dev_id_cert.sh

Lines changed: 12 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -11,23 +11,29 @@ if [ ! -f "$KEYCHAIN_PATH" ]; then
1111
security create-keychain -p "$KEYCHAIN_PASSWORD" "$KEYCHAIN_NAME"
1212
fi
1313

14+
# Make sure keychain doesn't auto-lock during the build
15+
# -l : lock after timeout
16+
# -u : lock when user logs out
17+
# -t : timeout in seconds (here: 6 hours)
18+
security set-keychain-settings -lut 21600 "$KEYCHAIN_PATH"
19+
1420
# Add keychain to the search list and make it default for this session
15-
security list-keychains -s "$KEYCHAIN_PATH"
21+
security list-keychains -s "$KEYCHAIN_PATH" $(security list-keychains | sed 's/[\",]//g')
1622
security default-keychain -s "$KEYCHAIN_PATH"
1723
security unlock-keychain -p "$KEYCHAIN_PASSWORD" "$KEYCHAIN_PATH"
1824

19-
# Import Developer ID certificate and allow all apps to access the private key
25+
# Import Developer ID certificate
2026
security import "$P12_PATH" \
2127
-k "$KEYCHAIN_PATH" \
2228
-P "$LARGE_SECRET_PASSPHRASE" \
29+
-A \
2330
-T /usr/bin/codesign \
2431
-T /usr/bin/productbuild \
25-
-T /usr/bin/security \
26-
-A
32+
-T /usr/bin/security
2733

28-
# Allow non-interactive access for codesign/productbuild/notarytool on CI
34+
# Allow non-interactive access for codesign / productbuild / notarytool
2935
security set-key-partition-list \
3036
-S apple-tool:,apple: \
3137
-s \
3238
-k "$KEYCHAIN_PASSWORD" \
33-
"$KEYCHAIN_PATH"
39+
"$KEYCHAIN_PATH"

.github/workflows/desktop.yaml

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@ jobs:
99
build_job:
1010
name: Package
1111
runs-on: ${{ matrix.os }}
12+
timeout-minutes: 25
1213
strategy:
1314
fail-fast: false
1415
matrix:
@@ -35,7 +36,7 @@ jobs:
3536
run: ./.github/scripts/import_macos_dev_id_cert.sh
3637
env:
3738
LARGE_SECRET_PASSPHRASE: ${{ secrets.LARGE_SECRET_PASSPHRASE }}
38-
- name: Debug code signing identities
39+
- name: Debug code signing identities (macOS)
3940
if: matrix.os == 'macos-latest'
4041
run: |
4142
security list-keychains
@@ -44,7 +45,13 @@ jobs:
4445
run: ./gradlew :app:desktop:packageReleaseUberJarForCurrentOS
4546
- name: Packaging (macOS)
4647
if: matrix.os == 'macos-latest'
48+
continue-on-error: true
4749
run: ./gradlew --no-configuration-cache :app:desktop:notarizeReleaseDmg
50+
- name: Debug hanging processes (macOS)
51+
if: always() && matrix.os == 'macos-latest'
52+
run: |
53+
echo "=== ps aux | egrep 'java|jpackage|codesign|notarytool' ==="
54+
ps aux | egrep 'java|jpackage|codesign|notarytool' || true
4855
- name: Packaging (Linux & Windows)
4956
if: matrix.os != 'macos-latest'
5057
run: ./gradlew packageReleaseDistributionForCurrentOS
@@ -55,4 +62,4 @@ jobs:
5562
app/desktop/build/compose/binaries/main-release/deb/*.deb
5663
app/desktop/build/compose/binaries/main-release/dmg/*.dmg
5764
app/desktop/build/compose/binaries/main-release/msi/*.msi
58-
app/desktop/build/compose/jars/*.jar
65+
app/desktop/build/compose/jars/*.jar

app/desktop/build.gradle.kts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ compose.desktop {
5050
nativeDistributions {
5151
targetFormats(TargetFormat.Dmg, TargetFormat.Msi, TargetFormat.Deb)
5252
packageName = "Note Delight"
53-
packageVersion = "8.4.605"
53+
packageVersion = "8.4.606"
5454
description = "Note app with encryption"
5555
copyright = "© 2023 SoftArtDev"
5656
macOS.iconFile.set(project.file("src/jvmMain/resources/app_icon.icns"))

0 commit comments

Comments
 (0)