refactor: encapsulate save change channel within NoteResult state

- Add `checkSaveChangeChannel` to the `NoteResult` data class to bundle the event stream with the UI state.
- Update `NoteViewModel` to provide the channel via the `NoteResult` state flow instead of a standalone property.
- Remove the `checkSaveChangeChannel` parameter from `AdaptiveMainScreen`, `NoteDetailScreen`, and `NoteDetail` composables to simplify function signatures.
- Adjust `NoteDetail` to observe the channel directly from the provided `NoteResult` object.
- Clean up unused imports and update UI previews to reflect the state changes.

Author: softartdev

app/android/src/main/java/com/softartdev/notedelight/ScreenshootPreview.kt

@@ -25,7 +25,6 @@ import com.softartdev.notedelight.ui.main.NoteDetailBody
 import com.softartdev.notedelight.ui.settings.AdaptiveSettingsScreen
 import com.softartdev.notedelight.ui.signin.SignInScreenBody
 import com.softartdev.theme.material3.PreferableMaterialTheme
-import kotlinx.coroutines.channels.Channel
 import kotlinx.coroutines.flow.flowOf
 import kotlinx.datetime.LocalDateTime
 
@@ -149,7 +148,6 @@ private fun StoreNotesScreen() {
         noteDetailState = remember { mutableStateOf(NoteResult(note = selectedNote)) },
         onMainAction = {},
         onNoteAction = {},
-        checkSaveChangeChannel = Channel()
     )
 }
 

core/presentation/src/commonMain/kotlin/com/softartdev/notedelight/presentation/note/NoteResult.kt

@@ -1,10 +1,12 @@
 package com.softartdev.notedelight.presentation.note
 
 import com.softartdev.notedelight.model.Note
+import kotlinx.coroutines.channels.Channel
 
 data class NoteResult(
     val loading: Boolean = false,
     val note: Note? = null,
+    val checkSaveChangeChannel: Channel<Unit> = Channel()
 ) {
     fun showLoading(): NoteResult = copy(loading = true)
     fun hideLoading(): NoteResult = copy(loading = false)

core/presentation/src/commonMain/kotlin/com/softartdev/notedelight/presentation/note/NoteViewModel.kt

@@ -17,7 +17,6 @@ import com.softartdev.notedelight.usecase.note.SaveNoteUseCase
 import com.softartdev.notedelight.usecase.note.UpdateTitleUseCase
 import com.softartdev.notedelight.util.CoroutineDispatchers
 import kotlinx.coroutines.Job
-import kotlinx.coroutines.channels.Channel
 import kotlinx.coroutines.flow.MutableStateFlow
 import kotlinx.coroutines.flow.StateFlow
 import kotlinx.coroutines.flow.update
@@ -35,12 +34,11 @@ class NoteViewModel(
     private val coroutineDispatchers: CoroutineDispatchers,
 ) : ViewModel() {
     private val logger = Logger.withTag(this@NoteViewModel::class.simpleName.toString())
-    private val mutableStateFlow: MutableStateFlow<NoteResult> = MutableStateFlow(NoteResult())
+    private val mutableStateFlow: MutableStateFlow<NoteResult> = MutableStateFlow(
+        value = NoteResult(checkSaveChangeChannel = adaptiveInteractor.checkSaveChangeChannel)
+    )
     val stateFlow: StateFlow<NoteResult> = mutableStateFlow
 
-    val checkSaveChangeChannel: Channel<Unit>
-        get() = adaptiveInteractor.checkSaveChangeChannel
-
     private var noteId: Long
         set(value) { adaptiveInteractor.selectedNoteIdStateFlow.value = value }
         get() = requireNotNull(adaptiveInteractor.selectedNoteIdStateFlow.value)

core/ui/src/commonMain/kotlin/com/softartdev/notedelight/ui/main/AdaptiveMainScreen.kt

@@ -32,7 +32,6 @@ import com.softartdev.notedelight.presentation.note.NoteViewModel
 import com.softartdev.notedelight.ui.NavBackHandler
 import com.softartdev.notedelight.ui.VerticalPaneExpansionDragHandle
 import com.softartdev.theme.material3.PreferableMaterialTheme
-import kotlinx.coroutines.channels.Channel
 import kotlinx.coroutines.launch
 import org.koin.compose.koinInject
 import org.koin.compose.viewmodel.koinViewModel
@@ -55,7 +54,6 @@ fun AdaptiveMainScreen(
         onMainAction = mainViewModel::onAction,
         noteDetailState = noteViewModel.stateFlow.collectAsState(),
         onNoteAction = noteViewModel::onAction,
-        checkSaveChangeChannel = noteViewModel.checkSaveChangeChannel
     )
 }
 
@@ -67,7 +65,6 @@ fun AdaptiveMainScreen(
     onMainAction: (action: MainAction) -> Unit,
     noteDetailState: State<NoteResult>,
     onNoteAction: (action: NoteAction) -> Unit,
-    checkSaveChangeChannel: Channel<Unit>
 ) {
     val coroutineScope = rememberCoroutineScope()
     val navigator: ThreePaneScaffoldNavigator<Long> = rememberListDetailPaneScaffoldNavigator<Long>()
@@ -81,7 +78,7 @@ fun AdaptiveMainScreen(
         directive = navigator.scaffoldDirective,
         value = navigator.scaffoldValue,
         listPane = { MainScreen(noteListResultState, onMainAction, snackbarHostState = snackbarHostState) },
-        detailPane = { NoteDetailScreen(noteDetailState, onNoteAction, checkSaveChangeChannel) },
+        detailPane = { NoteDetailScreen(noteDetailState, onNoteAction) },
         paneExpansionDragHandle = ThreePaneScaffoldScope::VerticalPaneExpansionDragHandle,
         paneExpansionState = paneExpansionState
     )

core/ui/src/commonMain/kotlin/com/softartdev/notedelight/ui/main/NoteDetail.kt

@@ -27,7 +27,6 @@ import androidx.compose.runtime.LaunchedEffect
 import androidx.compose.runtime.State
 import androidx.compose.runtime.collectAsState
 import androidx.compose.runtime.derivedStateOf
-import androidx.compose.runtime.getValue
 import androidx.compose.runtime.remember
 import androidx.compose.ui.Alignment
 import androidx.compose.ui.Modifier
@@ -38,14 +37,13 @@ import androidx.compose.ui.unit.dp
 import com.softartdev.notedelight.presentation.note.NoteAction
 import com.softartdev.notedelight.presentation.note.NoteResult
 import com.softartdev.notedelight.presentation.note.NoteViewModel
-import com.softartdev.notedelight.ui.NavBackHandler
 import com.softartdev.notedelight.ui.MainDetailPanePlaceholder
+import com.softartdev.notedelight.ui.NavBackHandler
 import com.softartdev.notedelight.ui.TooltipIconButton
 import com.softartdev.notedelight.util.DELETE_NOTE_BUTTON_TAG
 import com.softartdev.notedelight.util.EDIT_TITLE_BUTTON_TAG
 import com.softartdev.notedelight.util.SAVE_NOTE_BUTTON_TAG
 import com.softartdev.theme.material3.PreferableMaterialTheme
-import kotlinx.coroutines.channels.Channel
 import kotlinx.coroutines.flow.receiveAsFlow
 import notedelight.core.ui.generated.resources.Res
 import notedelight.core.ui.generated.resources.action_delete_note
@@ -62,28 +60,22 @@ fun NoteDetail(noteViewModel: NoteViewModel) {
         noteViewModel.launchCollectingSelectedNoteId()
     }
     val noteDetailState: State<NoteResult> = noteViewModel.stateFlow.collectAsState()
-    NoteDetailScreen(noteDetailState, noteViewModel::onAction, noteViewModel.checkSaveChangeChannel)
+    NoteDetailScreen(noteDetailState, noteViewModel::onAction)
 }
 
 @Composable
 fun NoteDetailScreen(
     noteDetailState: State<NoteResult>,
     onAction: (NoteAction) -> Unit,
-    checkSaveChangeChannel: Channel<Unit>
 ) = when (noteDetailState.value.note) {
     null -> MainDetailPanePlaceholder()
-    else -> NoteDetail(
-        result = noteDetailState.value,
-        onAction = onAction,
-        checkSaveChangeChannel = checkSaveChangeChannel
-    )
+    else -> NoteDetail(noteDetailState.value, onAction)
 }
 
 @Composable
 fun NoteDetail(
     result: NoteResult,
     onAction: (NoteAction) -> Unit,
-    checkSaveChangeChannel: Channel<Unit>
 ) {
     // Change selected note on adaptive (tablet) layout must change the text too.
     // The `rememberTextFieldState` and `rememberSaveable` doesn't support `key` parameters.
@@ -94,8 +86,8 @@ fun NoteDetail(
             initialSelection = TextRange(result.note?.text?.length ?: 0)
         )
     }
-    LaunchedEffect(checkSaveChangeChannel) {
-        checkSaveChangeChannel.receiveAsFlow().collect {
+    LaunchedEffect(key1 = result.checkSaveChangeChannel) {
+        result.checkSaveChangeChannel.receiveAsFlow().collect {
             onAction(NoteAction.ShowCheckSaveChangeDialog(textState.text))
         }
     }