From 08c5f34c265106cd809a806b9680f4db772fb126 Mon Sep 17 00:00:00 2001 From: Amir Arsalan Soltani Date: Thu, 23 Apr 2026 23:17:08 -0400 Subject: [PATCH 1/3] Update bridge_bidding.py --- pgx/bridge_bidding.py | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/pgx/bridge_bidding.py b/pgx/bridge_bidding.py index a39fc1bbc..668651e34 100644 --- a/pgx/bridge_bidding.py +++ b/pgx/bridge_bidding.py @@ -82,12 +82,11 @@ class State(core.State): # bidding_history stores the bid of each player in chronological order # Maximum length = 319 # Each element contains an integer representing an action: - # bid: 0 ~ 34 - # pass: 35 - # double: 36 - # redouble: 37 + # pass: 0 + # double: 1 + # redouble: 2 + # bid: 3 ~ 37 # no action: -1 - # TODO: change to pass = 0, double = 1, redouble = 2, bid = 3 ~ 37 # We can identify which player made each bid from the index of the element (ix % 4) _bidding_history: Array = jnp.full(319, -1, dtype=jnp.int32) # dealer: a player who starts bidding From 2d8aef505150296cd796d50a930829927d63018e Mon Sep 17 00:00:00 2001 From: Amir Arsalan Soltani Date: Thu, 23 Apr 2026 23:23:13 -0400 Subject: [PATCH 2/3] Update bridge_bidding.py --- pgx/bridge_bidding.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pgx/bridge_bidding.py b/pgx/bridge_bidding.py index 668651e34..ff56ac62d 100644 --- a/pgx/bridge_bidding.py +++ b/pgx/bridge_bidding.py @@ -85,7 +85,7 @@ class State(core.State): # pass: 0 # double: 1 # redouble: 2 - # bid: 3 ~ 37 + # bid: 3 ~ 37 (3=1C, 4=1D, 5=1H, 6=1S, ... 34=7C, 35=7D, 36=7H, 37=7S) # no action: -1 # We can identify which player made each bid from the index of the element (ix % 4) _bidding_history: Array = jnp.full(319, -1, dtype=jnp.int32) From 998f52195ad826bfb81c029eecb61fc409ea20b1 Mon Sep 17 00:00:00 2001 From: Amir Arsalan Soltani Date: Thu, 23 Apr 2026 23:37:42 -0400 Subject: [PATCH 3/3] Update bridge_bidding.py --- pgx/bridge_bidding.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pgx/bridge_bidding.py b/pgx/bridge_bidding.py index ff56ac62d..be257a918 100644 --- a/pgx/bridge_bidding.py +++ b/pgx/bridge_bidding.py @@ -85,7 +85,7 @@ class State(core.State): # pass: 0 # double: 1 # redouble: 2 - # bid: 3 ~ 37 (3=1C, 4=1D, 5=1H, 6=1S, ... 34=7C, 35=7D, 36=7H, 37=7S) + # bid: 3 ~ 37 (3=1C, 4=1D, 5=1H, 6=1S, 7=1NT, ... 33=7C, 34=7D, 35=7H, 36=7S, 37=7NT) # no action: -1 # We can identify which player made each bid from the index of the element (ix % 4) _bidding_history: Array = jnp.full(319, -1, dtype=jnp.int32)