diff --git a/cmd/zoekt-sourcegraph-indexserver/index.go b/cmd/zoekt-sourcegraph-indexserver/index.go index 36f55331b..8b527bfb9 100644 --- a/cmd/zoekt-sourcegraph-indexserver/index.go +++ b/cmd/zoekt-sourcegraph-indexserver/index.go @@ -389,9 +389,7 @@ func indexRepo(ctx context.Context, gitDir string, sourcegraph Sourcegraph, o *i // Even though we check for incremental in this process, we still pass it // in just in case we regress in how we check in process. We will still // notice thanks to metrics and increased load on gitserver. - if o.Incremental { - args = append(args, "-incremental") - } + args = append(args, fmt.Sprintf("-incremental=%v", o.Incremental)) var branches []string for _, b := range o.Branches { diff --git a/cmd/zoekt-sourcegraph-indexserver/index_test.go b/cmd/zoekt-sourcegraph-indexserver/index_test.go index 45b4fc355..5e643c937 100644 --- a/cmd/zoekt-sourcegraph-indexserver/index_test.go +++ b/cmd/zoekt-sourcegraph-indexserver/index_test.go @@ -499,7 +499,7 @@ func TestIndex(t *testing.T) { "git -C $TMPDIR/test%2Frepo.git config zoekt.public 0", "git -C $TMPDIR/test%2Frepo.git config zoekt.repoid 0", "git -C $TMPDIR/test%2Frepo.git config zoekt.tenantID 42", - "zoekt-git-index -submodules=false -branches HEAD -file_limit 1048576 -disable_ctags $TMPDIR/test%2Frepo.git", + "zoekt-git-index -submodules=false -incremental=false -branches HEAD -file_limit 1048576 -disable_ctags $TMPDIR/test%2Frepo.git", }, }, { name: "minimal-id", @@ -526,7 +526,7 @@ func TestIndex(t *testing.T) { "git -C $TMPDIR/test%2Frepo.git config zoekt.public 0", "git -C $TMPDIR/test%2Frepo.git config zoekt.repoid 123", "git -C $TMPDIR/test%2Frepo.git config zoekt.tenantID 1", - "zoekt-git-index -submodules=false -branches HEAD -file_limit 1048576 -disable_ctags $TMPDIR/test%2Frepo.git", + "zoekt-git-index -submodules=false -incremental=false -branches HEAD -file_limit 1048576 -disable_ctags $TMPDIR/test%2Frepo.git", }, }, { name: "all", @@ -561,7 +561,7 @@ func TestIndex(t *testing.T) { "git -C $TMPDIR/test%2Frepo.git config zoekt.public 0", "git -C $TMPDIR/test%2Frepo.git config zoekt.repoid 0", "git -C $TMPDIR/test%2Frepo.git config zoekt.tenantID 1", - "zoekt-git-index -submodules=false -incremental -branches HEAD,dev " + + "zoekt-git-index -submodules=false -incremental=true -branches HEAD,dev " + "-file_limit 1048576 -parallelism 4 -index /data/index -require_ctags -large_file foo -large_file bar " + "$TMPDIR/test%2Frepo.git", }, @@ -612,7 +612,7 @@ func TestIndex(t *testing.T) { "git -C $TMPDIR/test%2Frepo.git config zoekt.public 0", "git -C $TMPDIR/test%2Frepo.git config zoekt.repoid 0", "git -C $TMPDIR/test%2Frepo.git config zoekt.tenantID 1", - "zoekt-git-index -submodules=false -incremental -branches HEAD,dev,release " + + "zoekt-git-index -submodules=false -incremental=true -branches HEAD,dev,release " + "-delta -delta_threshold 22 -file_limit 1048576 -parallelism 4 -index /data/index -require_ctags -large_file foo -large_file bar " + "$TMPDIR/test%2Frepo.git", },