Skip to content

connection.request auto json encode #41

@Bloodiko

Description

@Bloodiko

The auto json encode on the ["data"] field is not a good idea, as "data" is usually supposed to be the body.
If you have a JSON body, you should send the "json" parameter instead of data, as they are mutually exclusive.

Excerpt from aiohttp doc

json – Any json compatible python object (optional). json and data parameters could not be used at the same time.

you dont even need to parse the data field into json, as aiohttp will do it for you.

As some of the lcu-api functions require plain-text / form encoded data, the data field should be passed along and not parsed.

Suggestion

Remove 'data'-autoparsing on the request and adjust the pydoc to the following.

Send JSON body data via the **json** keyword argument. The **data** keyword can be used for form based data. 
Both keywords (json and data) are mutually exclusive. Make sure to only send one.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions