From 82dbb6514b672242108abded228cb4f9c87ececc Mon Sep 17 00:00:00 2001 From: "google-labs-jules[bot]" <161369871+google-labs-jules[bot]@users.noreply.github.com> Date: Wed, 11 Feb 2026 08:25:32 +0000 Subject: [PATCH] Fix typos and capitalization in config and UI text - Fix `SQLLite` -> `SQLite` in `tavern/config.go` and `tavern/config_test.go`. - Fix `Github` -> `GitHub` and `Gitlab` -> `GitLab` capitalization in `tavern/internal/www/src/pages/tomes/components/StepAddDeploymentKey.tsx`. - Fix `Github` -> `GitHub` capitalization in `docs/README.md`. Ran `go fmt` and `go test` for backend changes. Frontend changes are text-only corrections. Co-authored-by: KCarretto <16250309+KCarretto@users.noreply.github.com> --- docs/README.md | 4 ++-- tavern/config.go | 2 +- tavern/config_test.go | 4 ++-- tavern/internal/cdn/download_link.go | 8 ++++---- tavern/internal/ent/schema/link_test.go | 6 +++--- tavern/internal/redirectors/tls.go | 11 +++++------ .../pages/tomes/components/StepAddDeploymentKey.tsx | 4 ++-- 7 files changed, 19 insertions(+), 20 deletions(-) diff --git a/docs/README.md b/docs/README.md index eccd0628a..04b2c0058 100644 --- a/docs/README.md +++ b/docs/README.md @@ -19,5 +19,5 @@ bundle exec jekyll serve --livereload ## Docsy Jekyll Template -* [Source on Github](https://github.com/vsoch/docsy-jekyll) -* [View on Github Pages](https://vsoch.github.io/docsy-jekyll/) +* [Source on GitHub](https://github.com/vsoch/docsy-jekyll) +* [View on GitHub Pages](https://vsoch.github.io/docsy-jekyll/) diff --git a/tavern/config.go b/tavern/config.go index 4c31a16ae..a188e1d6e 100644 --- a/tavern/config.go +++ b/tavern/config.go @@ -58,7 +58,7 @@ var ( EnvOAuthClientSecret = EnvString{"OAUTH_CLIENT_SECRET", ""} EnvOAuthDomain = EnvString{"OAUTH_DOMAIN", ""} - // EnvMySQLAddr defines the MySQL address to connect to, if unset SQLLite is used. + // EnvMySQLAddr defines the MySQL address to connect to, if unset SQLite is used. // EnvMySQLNet defines the network used to connect to MySQL (e.g. unix). // EnvMySQLUser defines the MySQL user to authenticate as. // EnvMySQLPasswd defines the password for the MySQL user to authenticate with. diff --git a/tavern/config_test.go b/tavern/config_test.go index 84a85230d..82f5d733f 100644 --- a/tavern/config_test.go +++ b/tavern/config_test.go @@ -27,7 +27,7 @@ func TestConfigureMySQLFromEnv(t *testing.T) { require.NoError(t, os.Unsetenv(EnvDBMaxConnLifetime.Key)) } - t.Run("SQLLite", func(t *testing.T) { + t.Run("SQLite", func(t *testing.T) { defer cleanup() cfg := &Config{} @@ -80,7 +80,7 @@ func TestConfigureMySQLFromEnv(t *testing.T) { assert.Equal(t, "root@tcp(127.0.0.1)/tavern?parseTime=true", cfg.mysqlDSN) }) - t.Run("SQLLite", func(t *testing.T) { + t.Run("SQLite", func(t *testing.T) { defer cleanup() require.NoError(t, os.Setenv(EnvDBMaxIdleConns.Key, "1337")) require.NoError(t, os.Setenv(EnvDBMaxOpenConns.Key, "420")) diff --git a/tavern/internal/cdn/download_link.go b/tavern/internal/cdn/download_link.go index 07e706d86..3953f8548 100644 --- a/tavern/internal/cdn/download_link.go +++ b/tavern/internal/cdn/download_link.go @@ -2,8 +2,8 @@ package cdn import ( "bytes" - "net/http" "log/slog" + "net/http" "strings" "time" @@ -55,15 +55,15 @@ func NewLinkDownloadHandler(graph *ent.Client, prefix string) http.Handler { if l.DownloadLimit != nil { downloadLimit = *l.DownloadLimit } - if downloadLimit > 0 && l.Downloads >= downloadLimit { + if downloadLimit > 0 && l.Downloads >= downloadLimit { slog.Info("Failed attempt to download link, maximum downloads reached", "path", linkPath, "downloads", l.Downloads, "download_limit", l.DownloadLimit) return ErrFileNotFound } // Increment Link Downloads if _, err := graph.Link.UpdateOne(l). - SetDownloads(l.Downloads + 1). - Save(ctx); err != nil { + SetDownloads(l.Downloads + 1). + Save(ctx); err != nil { slog.Error("failed to increment downloads for link", "path", linkPath, "downloads", l.Downloads, "err", err) // Only error if a download limit is enforced diff --git a/tavern/internal/ent/schema/link_test.go b/tavern/internal/ent/schema/link_test.go index 1cfc2e702..1639bb127 100644 --- a/tavern/internal/ent/schema/link_test.go +++ b/tavern/internal/ent/schema/link_test.go @@ -30,9 +30,9 @@ func TestCreateLinkWithExplicitExpiresAt(t *testing.T) { futureTime := time.Now().Add(24 * time.Hour) downloadLimit := 5 input := ent.CreateLinkInput{ - AssetID: asset.ID, - DownloadLimit: &downloadLimit, - ExpiresAt: &futureTime, + AssetID: asset.ID, + DownloadLimit: &downloadLimit, + ExpiresAt: &futureTime, } link, err := graph.Link.Create().SetInput(input).Save(ctx) diff --git a/tavern/internal/redirectors/tls.go b/tavern/internal/redirectors/tls.go index e45ec0fc6..850643d19 100644 --- a/tavern/internal/redirectors/tls.go +++ b/tavern/internal/redirectors/tls.go @@ -51,9 +51,9 @@ func tryACME(ctx context.Context, host string) (tlsCfg *tls.Config, err error) { slog.Debug("redirectors: using short lived certificates") } acme := certmagic.ACMEIssuer{ - Agreed: true, - Email: "", - CA: certmagic.LetsEncryptProductionCA, + Agreed: true, + Email: "", + CA: certmagic.LetsEncryptProductionCA, Profile: profile, } @@ -85,9 +85,8 @@ func selfSignedTLSConfig(host string) (*tls.Config, error) { } template := x509.Certificate{ - SerialNumber: serialNumber, - Subject: pkix.Name{ - }, + SerialNumber: serialNumber, + Subject: pkix.Name{}, NotBefore: time.Now(), NotAfter: time.Now().Add(365 * 24 * time.Hour), KeyUsage: x509.KeyUsageDigitalSignature | x509.KeyUsageKeyEncipherment, diff --git a/tavern/internal/www/src/pages/tomes/components/StepAddDeploymentKey.tsx b/tavern/internal/www/src/pages/tomes/components/StepAddDeploymentKey.tsx index 1d54989d0..268235ec8 100644 --- a/tavern/internal/www/src/pages/tomes/components/StepAddDeploymentKey.tsx +++ b/tavern/internal/www/src/pages/tomes/components/StepAddDeploymentKey.tsx @@ -26,8 +26,8 @@ const StepAddDeploymentKey: FC = ({ setCurrStep, newR To import tomes, you need to give Realm access to your git repository. Copy the public key below into your repositories deployment keys, often found in admin settings.