From 7cfb698507d816204f25560f9010143ed5b5a62e Mon Sep 17 00:00:00 2001 From: Bill Al Date: Thu, 5 Feb 2026 20:22:38 -0800 Subject: [PATCH 1/8] disabled events for redis and localhost modes --- LICENSE.txt | 182 ++++++++++++++++-- .../Services/Client/Classes/RedisClient.cs | 2 +- Splitio.Redis/Splitio.Redis.csproj | 2 +- .../Services/Client/Classes/JSONFileClient.cs | 2 +- .../Client/Classes/LocalhostClient.cs | 2 +- .../Client/Classes/SelfRefreshingClient.cs | 2 +- .../Services/Client/Classes/SplitClient.cs | 30 ++- .../Services/Tasks/NoOpInternalEventsTask.cs | 19 ++ src/Splitio/Splitio.csproj | 2 +- .../Client/SplitClientForTesting.cs | 2 +- .../Splitio.TestSupport/SplitClientForTest.cs | 2 +- 11 files changed, 218 insertions(+), 29 deletions(-) create mode 100644 src/Splitio/Services/Tasks/NoOpInternalEventsTask.cs diff --git a/LICENSE.txt b/LICENSE.txt index c022e920..7fbcdda5 100644 --- a/LICENSE.txt +++ b/LICENSE.txt @@ -1,13 +1,169 @@ -Copyright © 2024 Split Software, Inc. - -Licensed under the Apache License, Version 2.0 (the "License"); -you may not use this file except in compliance with the License. -You may obtain a copy of the License at - - http://www.apache.org/licenses/LICENSE-2.0 - -Unless required by applicable law or agreed to in writing, software -distributed under the License is distributed on an "AS IS" BASIS, -WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. -See the License for the specific language governing permissions and -limitations under the License. +Apache License + Version 2.0, January 2004 + http://www.apache.org/licenses/ + TERMS AND CONDITIONS FOR USE, REPRODUCTION, AND DISTRIBUTION + 1. Definitions. + "License" shall mean the terms and conditions for use, reproduction, + and distribution as defined by Sections 1 through 9 of this document. + "Licensor" shall mean the copyright owner or entity authorized by + the copyright owner that is granting the License. + "Legal Entity" shall mean the union of the acting entity and all + other entities that control, are controlled by, or are under common + control with that entity. For the purposes of this definition, + "control" means (i) the power, direct or indirect, to cause the + direction or management of such entity, whether by contract or + otherwise, or (ii) ownership of fifty percent (50%) or more of the + outstanding shares, or (iii) beneficial ownership of such entity. + "You" (or "Your") shall mean an individual or Legal Entity + exercising permissions granted by this License. + "Source" form shall mean the preferred form for making modifications, + including but not limited to software source code, documentation + source, and configuration files. + "Object" form shall mean any form resulting from mechanical + transformation or translation of a Source form, including but + not limited to compiled object code, generated documentation, + and conversions to other media types. + "Work" shall mean the work of authorship, whether in Source or + Object form, made available under the License, as indicated by a + copyright notice that is included in or attached to the work + (an example is provided in the Appendix below). + "Derivative Works" shall mean any work, whether in Source or Object + form, that is based on (or derived from) the Work and for which the + editorial revisions, annotations, elaborations, or other modifications + represent, as a whole, an original work of authorship. For the purposes + of this License, Derivative Works shall not include works that remain + separable from, or merely link (or bind by name) to the interfaces of, + the Work and Derivative Works thereof. + "Contribution" shall mean any work of authorship, including + the original version of the Work and any modifications or additions + to that Work or Derivative Works thereof, that is intentionally + submitted to Licensor for inclusion in the Work by the copyright owner + or by an individual or Legal Entity authorized to submit on behalf of + the copyright owner. For the purposes of this definition, "submitted" + means any form of electronic, verbal, or written communication sent + to the Licensor or its representatives, including but not limited to + communication on electronic mailing lists, source code control systems, + and issue tracking systems that are managed by, or on behalf of, the + Licensor for the purpose of discussing and improving the Work, but + excluding communication that is conspicuously marked or otherwise + designated in writing by the copyright owner as "Not a Contribution." + "Contributor" shall mean Licensor and any individual or Legal Entity + on behalf of whom a Contribution has been received by Licensor and + subsequently incorporated within the Work. + 2. Grant of Copyright License. Subject to the terms and conditions of + this License, each Contributor hereby grants to You a perpetual, + worldwide, non-exclusive, no-charge, royalty-free, irrevocable + copyright license to reproduce, prepare Derivative Works of, + publicly display, publicly perform, sublicense, and distribute the + Work and such Derivative Works in Source or Object form. + 3. Grant of Patent License. Subject to the terms and conditions of + this License, each Contributor hereby grants to You a perpetual, + worldwide, non-exclusive, no-charge, royalty-free, irrevocable + (except as stated in this section) patent license to make, have made, + use, offer to sell, sell, import, and otherwise transfer the Work, + where such license applies only to those patent claims licensable + by such Contributor that are necessarily infringed by their + Contribution(s) alone or by combination of their Contribution(s) + with the Work to which such Contribution(s) was submitted. If You + institute patent litigation against any entity (including a + cross-claim or counterclaim in a lawsuit) alleging that the Work + or a Contribution incorporated within the Work constitutes direct + or contributory patent infringement, then any patent licenses + granted to You under this License for that Work shall terminate + as of the date such litigation is filed. + 4. Redistribution. You may reproduce and distribute copies of the + Work or Derivative Works thereof in any medium, with or without + modifications, and in Source or Object form, provided that You + meet the following conditions: + (a) You must give any other recipients of the Work or + Derivative Works a copy of this License; and + (b) You must cause any modified files to carry prominent notices + stating that You changed the files; and + (c) You must retain, in the Source form of any Derivative Works + that You distribute, all copyright, patent, trademark, and + attribution notices from the Source form of the Work, + excluding those notices that do not pertain to any part of + the Derivative Works; and + (d) If the Work includes a "NOTICE" text file as part of its + distribution, then any Derivative Works that You distribute must + include a readable copy of the attribution notices contained + within such NOTICE file, excluding those notices that do not + pertain to any part of the Derivative Works, in at least one + of the following places: within a NOTICE text file distributed + as part of the Derivative Works; within the Source form or + documentation, if provided along with the Derivative Works; or, + within a display generated by the Derivative Works, if and + wherever such third-party notices normally appear. The contents + of the NOTICE file are for informational purposes only and + do not modify the License. You may add Your own attribution + notices within Derivative Works that You distribute, alongside + or as an addendum to the NOTICE text from the Work, provided + that such additional attribution notices cannot be construed + as modifying the License. + You may add Your own copyright statement to Your modifications and + may provide additional or different license terms and conditions + for use, reproduction, or distribution of Your modifications, or + for any such Derivative Works as a whole, provided Your use, + reproduction, and distribution of the Work otherwise complies with + the conditions stated in this License. + 5. Submission of Contributions. Unless You explicitly state otherwise, + any Contribution intentionally submitted for inclusion in the Work + by You to the Licensor shall be under the terms and conditions of + this License, without any additional terms or conditions. + Notwithstanding the above, nothing herein shall supersede or modify + the terms of any separate license agreement you may have executed + with Licensor regarding such Contributions. + 6. Trademarks. This License does not grant permission to use the trade + names, trademarks, service marks, or product names of the Licensor, + except as required for reasonable and customary use in describing the + origin of the Work and reproducing the content of the NOTICE file. + 7. Disclaimer of Warranty. Unless required by applicable law or + agreed to in writing, Licensor provides the Work (and each + Contributor provides its Contributions) on an "AS IS" BASIS, + WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or + implied, including, without limitation, any warranties or conditions + of TITLE, NON-INFRINGEMENT, MERCHANTABILITY, or FITNESS FOR A + PARTICULAR PURPOSE. You are solely responsible for determining the + appropriateness of using or redistributing the Work and assume any + risks associated with Your exercise of permissions under this License. + 8. Limitation of Liability. In no event and under no legal theory, + whether in tort (including negligence), contract, or otherwise, + unless required by applicable law (such as deliberate and grossly + negligent acts) or agreed to in writing, shall any Contributor be + liable to You for damages, including any direct, indirect, special, + incidental, or consequential damages of any character arising as a + result of this License or out of the use or inability to use the + Work (including but not limited to damages for loss of goodwill, + work stoppage, computer failure or malfunction, or any and all + other commercial damages or losses), even if such Contributor + has been advised of the possibility of such damages. + 9. Accepting Warranty or Additional Liability. While redistributing + the Work or Derivative Works thereof, You may choose to offer, + and charge a fee for, acceptance of support, warranty, indemnity, + or other liability obligations and/or rights consistent with this + License. However, in accepting such obligations, You may act only + on Your own behalf and on Your sole responsibility, not on behalf + of any other Contributor, and only if You agree to indemnify, + defend, and hold each Contributor harmless for any liability + incurred by, or claims asserted against, such Contributor by reason + of your accepting any such warranty or additional liability. + END OF TERMS AND CONDITIONS + APPENDIX: How to apply the Apache License to your work. + To apply the Apache License to your work, attach the following + boilerplate notice, with the fields enclosed by brackets "[]" + replaced with your own identifying information. (Don't include + the brackets!) The text should be enclosed in the appropriate + comment syntax for the file format. We also recommend that a + file or class name and description of purpose be included on the + same "printed page" as the copyright notice for easier + identification within third-party archives. + Copyright 2026 harness corporation + Licensed under the Apache License, Version 2.0 (the "License"); + you may not use this file except in compliance with the License. + You may obtain a copy of the License at + http://www.apache.org/licenses/LICENSE-2.0 + Unless required by applicable law or agreed to in writing, software + distributed under the License is distributed on an "AS IS" BASIS, + WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + See the License for the specific language governing permissions and + limitations under the License. \ No newline at end of file diff --git a/Splitio.Redis/Services/Client/Classes/RedisClient.cs b/Splitio.Redis/Services/Client/Classes/RedisClient.cs index d36a6cf4..b696ab48 100644 --- a/Splitio.Redis/Services/Client/Classes/RedisClient.cs +++ b/Splitio.Redis/Services/Client/Classes/RedisClient.cs @@ -29,7 +29,7 @@ public class RedisClient : SplitClient private ConnectionPoolManager _connectionPoolManager; private IFeatureFlagCacheConsumer _featureFlagCacheConsumer; - public RedisClient(ConfigurationOptions config, string apiKey) : base(apiKey) + public RedisClient(ConfigurationOptions config, string apiKey) : base(apiKey, config.Mode) { _config = new RedisConfig(); diff --git a/Splitio.Redis/Splitio.Redis.csproj b/Splitio.Redis/Splitio.Redis.csproj index ec925af2..ed6c646d 100644 --- a/Splitio.Redis/Splitio.Redis.csproj +++ b/Splitio.Redis/Splitio.Redis.csproj @@ -7,7 +7,7 @@ false false false - 7.13.0-rc1 + 7.13.0-rc2 true SplitioRedis.snk Apache-2.0 diff --git a/src/Splitio/Services/Client/Classes/JSONFileClient.cs b/src/Splitio/Services/Client/Classes/JSONFileClient.cs index 34bd7194..f9b0b1a0 100644 --- a/src/Splitio/Services/Client/Classes/JSONFileClient.cs +++ b/src/Splitio/Services/Client/Classes/JSONFileClient.cs @@ -32,7 +32,7 @@ public JSONFileClient(string splitsFilePath, ITrafficTypeValidator trafficTypeValidator = null, IImpressionsManager impressionsManager = null, IRuleBasedSegmentCache ruleBasedSegmentCache = null - ) : base("localhost") + ) : base("localhost", config.Mode) { _segmentCache = segmentCacheInstance ?? new InMemorySegmentCache(new ConcurrentDictionary(), _internalEventsTask); var rbsCache = ruleBasedSegmentCache ?? new InMemoryRuleBasedSegmentCache(new ConcurrentDictionary(), _internalEventsTask); diff --git a/src/Splitio/Services/Client/Classes/LocalhostClient.cs b/src/Splitio/Services/Client/Classes/LocalhostClient.cs index 92cb305f..1dd8d082 100644 --- a/src/Splitio/Services/Client/Classes/LocalhostClient.cs +++ b/src/Splitio/Services/Client/Classes/LocalhostClient.cs @@ -27,7 +27,7 @@ public class LocalhostClient : SplitClient private readonly object _lock = new object(); - public LocalhostClient(ConfigurationOptions configurationOptions) : base("localhost") + public LocalhostClient(ConfigurationOptions configurationOptions) : base("localhost", configurationOptions.Mode) { var configs = (LocalhostClientConfigurations)_configService.ReadConfig(configurationOptions, ConfigTypes.Localhost, _statusManager); diff --git a/src/Splitio/Services/Client/Classes/SelfRefreshingClient.cs b/src/Splitio/Services/Client/Classes/SelfRefreshingClient.cs index b90e6e74..8afa8312 100644 --- a/src/Splitio/Services/Client/Classes/SelfRefreshingClient.cs +++ b/src/Splitio/Services/Client/Classes/SelfRefreshingClient.cs @@ -52,7 +52,7 @@ public class SelfRefreshingClient : SplitClient private IRuleBasedSegmentCache _ruleBasedSegmentCache; private IUpdater _ruleBasedSegmentUpdater; - public SelfRefreshingClient(string apiKey, ConfigurationOptions config) : base(apiKey) + public SelfRefreshingClient(string apiKey, ConfigurationOptions config) : base(apiKey, config.Mode) { _config = (SelfRefreshingConfig)_configService.ReadConfig(config, ConfigTypes.InMemory); diff --git a/src/Splitio/Services/Client/Classes/SplitClient.cs b/src/Splitio/Services/Client/Classes/SplitClient.cs index ef5867ab..86817c7e 100644 --- a/src/Splitio/Services/Client/Classes/SplitClient.cs +++ b/src/Splitio/Services/Client/Classes/SplitClient.cs @@ -66,6 +66,7 @@ public abstract class SplitClient : ISplitClient protected IEventsManager _eventsManager; protected IInternalEventsTask _internalEventsTask; private EventHandler SdkReadyEvent; + private Mode _configMode; public event EventHandler SdkReady { @@ -85,14 +86,24 @@ public event EventHandler SdkReady } public event EventHandler SdkUpdate; - protected SplitClient(string apikey) + protected SplitClient(string apikey, Mode configMode) { ApiKey = apikey; - _eventsManager = new EventsManager(new EventsManagerConfig(), new EventDelivery()); - _internalEventsTask = new InternalEventsTask(_eventsManager, new SplitQueue()); - _internalEventsTask.Start(); - RegisterEvents(); - + _configMode = configMode; + + if (configMode == Mode.Standalone) + { + _eventsManager = new EventsManager(new EventsManagerConfig(), new EventDelivery()); + _internalEventsTask = new InternalEventsTask(_eventsManager, new SplitQueue()); + _internalEventsTask.Start(); + RegisterEvents(); + } + else + { + _eventsManager = null; + _internalEventsTask = new NoOpInternalEventsTask(); + } + _wrapperAdapter = WrapperAdapter.Instance(); _keyValidator = new KeyValidator(); _splitNameValidator = new SplitNameValidator(); @@ -521,8 +532,11 @@ private void RegisterEvents() } private void UnregisterEvents() { - _eventsManager.Unregister(SdkEvent.SdkReady); - _eventsManager.Unregister(SdkEvent.SdkUpdate); + if (_configMode == Mode.Standalone) + { + _eventsManager.Unregister(SdkEvent.SdkReady); + _eventsManager.Unregister(SdkEvent.SdkUpdate); + } } private List GetTreatmentsSync(Enums.API method, Key key, List features, Dictionary attributes = null, EvaluationOptions evaluationOptions = null) { diff --git a/src/Splitio/Services/Tasks/NoOpInternalEventsTask.cs b/src/Splitio/Services/Tasks/NoOpInternalEventsTask.cs new file mode 100644 index 00000000..938130c0 --- /dev/null +++ b/src/Splitio/Services/Tasks/NoOpInternalEventsTask.cs @@ -0,0 +1,19 @@ +using Splitio.Domain; +using System.Threading.Tasks; + +namespace Splitio.Services.Tasks +{ + public class NoOpInternalEventsTask : IInternalEventsTask + { + public NoOpInternalEventsTask() + { + return; + } + public async Task AddToQueue(SdkInternalEvent sdkInternalEvent, EventMetadata eventMetadata) + { return; } + + public void Start() { return; } + + public void Stop() { return; } + } +} diff --git a/src/Splitio/Splitio.csproj b/src/Splitio/Splitio.csproj index 95302642..8f059f77 100644 --- a/src/Splitio/Splitio.csproj +++ b/src/Splitio/Splitio.csproj @@ -7,7 +7,7 @@ false false false - 7.13.0-rc1 + 7.13.0-rc2 Splitio true Splitio.snk diff --git a/tests/Splitio-tests/Unit Tests/Client/SplitClientForTesting.cs b/tests/Splitio-tests/Unit Tests/Client/SplitClientForTesting.cs index fe11a14e..2f741162 100644 --- a/tests/Splitio-tests/Unit Tests/Client/SplitClientForTesting.cs +++ b/tests/Splitio-tests/Unit Tests/Client/SplitClientForTesting.cs @@ -22,7 +22,7 @@ public SplitClientForTesting(IFeatureFlagCacheConsumer featureFlagCacheConsumer, ISyncManager syncManager, ITelemetryEvaluationProducer telemetryEvaluationProducer, IFallbackTreatmentCalculator fallbackTreatmentCalculator) - : base("SplitClientForTesting") + : base("SplitClientForTesting", Mode.Standalone) { _fallbackTreatmentCalculator = fallbackTreatmentCalculator; _eventsLog = eventsLog; diff --git a/tests/Splitio.TestSupport/SplitClientForTest.cs b/tests/Splitio.TestSupport/SplitClientForTest.cs index 9f453fc1..8c29c458 100644 --- a/tests/Splitio.TestSupport/SplitClientForTest.cs +++ b/tests/Splitio.TestSupport/SplitClientForTest.cs @@ -8,7 +8,7 @@ public class SplitClientForTest : SplitClient { private readonly Dictionary _tests; - public SplitClientForTest(ConfigurationOptions config) : base("SplitClientForTest") + public SplitClientForTest(ConfigurationOptions config) : base("SplitClientForTest", config.Mode) { BuildFallbackCalculator(config.FallbackTreatments); _tests = new Dictionary(); From 120d3640a5eb900d3b87a0b7b39b92f7568064d5 Mon Sep 17 00:00:00 2001 From: Bill Al Date: Tue, 3 Mar 2026 14:09:42 -0800 Subject: [PATCH 2/8] removed mode from splitclient init --- .../Services/Client/Classes/RedisClient.cs | 15 +++++- .../Services/Client/Classes/JSONFileClient.cs | 4 +- .../Client/Classes/LocalhostClient.cs | 4 +- .../Client/Classes/SelfRefreshingClient.cs | 4 +- .../Services/Client/Classes/SplitClient.cs | 49 ++++++++++--------- .../Client/SplitClientForTesting.cs | 5 +- .../Splitio.TestSupport/SplitClientForTest.cs | 3 +- .../BaseAsyncClientTests.cs | 5 +- 8 files changed, 56 insertions(+), 33 deletions(-) diff --git a/Splitio.Redis/Services/Client/Classes/RedisClient.cs b/Splitio.Redis/Services/Client/Classes/RedisClient.cs index b696ab48..88c0b16a 100644 --- a/Splitio.Redis/Services/Client/Classes/RedisClient.cs +++ b/Splitio.Redis/Services/Client/Classes/RedisClient.cs @@ -16,6 +16,7 @@ using Splitio.Services.InputValidation.Classes; using Splitio.Services.Parsing; using Splitio.Services.Shared.Classes; +using Splitio.Services.Tasks; namespace Splitio.Redis.Services.Client.Classes { @@ -29,12 +30,16 @@ public class RedisClient : SplitClient private ConnectionPoolManager _connectionPoolManager; private IFeatureFlagCacheConsumer _featureFlagCacheConsumer; - public RedisClient(ConfigurationOptions config, string apiKey) : base(apiKey, config.Mode) + public RedisClient(ConfigurationOptions config, string apiKey) : base(apiKey) { _config = new RedisConfig(); ReadConfig(config); - + + _eventsManager = null; + _internalEventsTask = new NoOpInternalEventsTask(); +// BuildEventsManager(); + BuildStatusAndTaskManager(); BuildFallbackCalculator(_config.FallbackTreatments); BuildRedisCache(); BuildTreatmentLog(config.ImpressionListener); @@ -54,6 +59,12 @@ public RedisClient(ConfigurationOptions config, string apiKey) : base(apiKey, co _syncManager.Start(); } + + override protected void BuildEventsManager() + { + _eventsManager = null; + _internalEventsTask = new NoOpInternalEventsTask(); + } #region Private Methods private void ReadConfig(ConfigurationOptions config) diff --git a/src/Splitio/Services/Client/Classes/JSONFileClient.cs b/src/Splitio/Services/Client/Classes/JSONFileClient.cs index f9b0b1a0..be7e9d42 100644 --- a/src/Splitio/Services/Client/Classes/JSONFileClient.cs +++ b/src/Splitio/Services/Client/Classes/JSONFileClient.cs @@ -32,7 +32,7 @@ public JSONFileClient(string splitsFilePath, ITrafficTypeValidator trafficTypeValidator = null, IImpressionsManager impressionsManager = null, IRuleBasedSegmentCache ruleBasedSegmentCache = null - ) : base("localhost", config.Mode) + ) : base("localhost") { _segmentCache = segmentCacheInstance ?? new InMemorySegmentCache(new ConcurrentDictionary(), _internalEventsTask); var rbsCache = ruleBasedSegmentCache ?? new InMemoryRuleBasedSegmentCache(new ConcurrentDictionary(), _internalEventsTask); @@ -52,6 +52,8 @@ public JSONFileClient(string splitsFilePath, parsedSplits.TryAdd(split.name, _splitParser.Parse(split, rbsCache)); } + BuildEventsManager(); + BuildStatusAndTaskManager(); BuildFallbackCalculator(config.FallbackTreatments); BuildFlagSetsFilter(new HashSet()); _featureFlagCache = featureFlagCacheInstance ?? new InMemorySplitCache(new ConcurrentDictionary(parsedSplits), _flagSetsFilter, _internalEventsTask); diff --git a/src/Splitio/Services/Client/Classes/LocalhostClient.cs b/src/Splitio/Services/Client/Classes/LocalhostClient.cs index 1dd8d082..de98f934 100644 --- a/src/Splitio/Services/Client/Classes/LocalhostClient.cs +++ b/src/Splitio/Services/Client/Classes/LocalhostClient.cs @@ -27,8 +27,10 @@ public class LocalhostClient : SplitClient private readonly object _lock = new object(); - public LocalhostClient(ConfigurationOptions configurationOptions) : base("localhost", configurationOptions.Mode) + public LocalhostClient(ConfigurationOptions configurationOptions) : base("localhost") { + BuildEventsManager(); + BuildStatusAndTaskManager(); var configs = (LocalhostClientConfigurations)_configService.ReadConfig(configurationOptions, ConfigTypes.Localhost, _statusManager); _fullPath = LookupFilePath(configs.FilePath); diff --git a/src/Splitio/Services/Client/Classes/SelfRefreshingClient.cs b/src/Splitio/Services/Client/Classes/SelfRefreshingClient.cs index 8afa8312..4bb3b6b3 100644 --- a/src/Splitio/Services/Client/Classes/SelfRefreshingClient.cs +++ b/src/Splitio/Services/Client/Classes/SelfRefreshingClient.cs @@ -52,10 +52,12 @@ public class SelfRefreshingClient : SplitClient private IRuleBasedSegmentCache _ruleBasedSegmentCache; private IUpdater _ruleBasedSegmentUpdater; - public SelfRefreshingClient(string apiKey, ConfigurationOptions config) : base(apiKey, config.Mode) + public SelfRefreshingClient(string apiKey, ConfigurationOptions config) : base(apiKey) { _config = (SelfRefreshingConfig)_configService.ReadConfig(config, ConfigTypes.InMemory); + BuildEventsManager(); + BuildStatusAndTaskManager(); BuildFallbackCalculator(_config.FallbackTreatments); BuildFlagSetsFilter(_config.FlagSetsFilter); BuildSplitCache(); diff --git a/src/Splitio/Services/Client/Classes/SplitClient.cs b/src/Splitio/Services/Client/Classes/SplitClient.cs index 86817c7e..f719150b 100644 --- a/src/Splitio/Services/Client/Classes/SplitClient.cs +++ b/src/Splitio/Services/Client/Classes/SplitClient.cs @@ -86,24 +86,9 @@ public event EventHandler SdkReady } public event EventHandler SdkUpdate; - protected SplitClient(string apikey, Mode configMode) + protected SplitClient(string apikey) { ApiKey = apikey; - _configMode = configMode; - - if (configMode == Mode.Standalone) - { - _eventsManager = new EventsManager(new EventsManagerConfig(), new EventDelivery()); - _internalEventsTask = new InternalEventsTask(_eventsManager, new SplitQueue()); - _internalEventsTask.Start(); - RegisterEvents(); - } - else - { - _eventsManager = null; - _internalEventsTask = new NoOpInternalEventsTask(); - } - _wrapperAdapter = WrapperAdapter.Instance(); _keyValidator = new KeyValidator(); _splitNameValidator = new SplitNameValidator(); @@ -112,8 +97,6 @@ protected SplitClient(string apikey, Mode configMode) _factoryInstantiationsService = FactoryInstantiationsService.Instance(); _flagSetsValidator = new FlagSetsValidator(); _configService = new ConfigService(_wrapperAdapter, _flagSetsValidator, new SdkMetadataValidator()); - _statusManager = new InMemoryReadinessGatesCache(_internalEventsTask); - _tasksManager = new TasksManager(_statusManager); } #region GetTreatment @@ -330,12 +313,14 @@ public virtual async Task DestroyAsync() if (_statusManager.IsDestroyed()) return; _log.Info(Messages.InitDestroy); - _internalEventsTask.Stop(); _factoryInstantiationsService.Decrease(ApiKey); _statusManager.SetDestroy(); await _syncManager.ShutdownAsync(); - UnregisterEvents(); - + if (_eventsManager != null) + { + _internalEventsTask.Stop(); + UnregisterEvents(); + } _log.Info(Messages.Destroyed); } @@ -345,12 +330,14 @@ public virtual void Destroy() _log.Info(Messages.InitDestroy); - _internalEventsTask.Stop(); _factoryInstantiationsService.Decrease(ApiKey); _statusManager.SetDestroy(); _syncManager.Shutdown(); - UnregisterEvents(); - + if (_eventsManager != null) + { + _internalEventsTask.Stop(); + UnregisterEvents(); + } _log.Info(Messages.Destroyed); } #endregion @@ -427,6 +414,12 @@ public ISplitManager GetSplitManager() #endregion #region Protected Methods + protected void BuildStatusAndTaskManager() + { + _statusManager = new InMemoryReadinessGatesCache(_internalEventsTask); + _tasksManager = new TasksManager(_statusManager); + } + protected void BuildUniqueKeysTracker(BaseConfig config) { var bloomFilter = new BloomFilter(config.BfExpectedElements, config.BfErrorRate); @@ -464,6 +457,14 @@ protected void BuildFallbackCalculator(FallbackTreatmentsConfiguration fallbackT { _fallbackTreatmentCalculator = new FallbackTreatmentCalculator(fallbackTreatmentsConfiguration); } + + protected virtual void BuildEventsManager() + { + _eventsManager = new EventsManager(new EventsManagerConfig(), new EventDelivery()); + _internalEventsTask = new InternalEventsTask(_eventsManager, new SplitQueue()); + _internalEventsTask.Start(); + RegisterEvents(); + } #endregion #region Private Async Methods diff --git a/tests/Splitio-tests/Unit Tests/Client/SplitClientForTesting.cs b/tests/Splitio-tests/Unit Tests/Client/SplitClientForTesting.cs index 2f741162..84d50592 100644 --- a/tests/Splitio-tests/Unit Tests/Client/SplitClientForTesting.cs +++ b/tests/Splitio-tests/Unit Tests/Client/SplitClientForTesting.cs @@ -22,8 +22,10 @@ public SplitClientForTesting(IFeatureFlagCacheConsumer featureFlagCacheConsumer, ISyncManager syncManager, ITelemetryEvaluationProducer telemetryEvaluationProducer, IFallbackTreatmentCalculator fallbackTreatmentCalculator) - : base("SplitClientForTesting", Mode.Standalone) + : base("SplitClientForTesting") { + BuildEventsManager(); + BuildStatusAndTaskManager(); _fallbackTreatmentCalculator = fallbackTreatmentCalculator; _eventsLog = eventsLog; _impressionsLog = impressionsLog; @@ -33,7 +35,6 @@ public SplitClientForTesting(IFeatureFlagCacheConsumer featureFlagCacheConsumer, _impressionsManager = impressionsManager; _syncManager = syncManager; _telemetryEvaluationProducer = telemetryEvaluationProducer; - BuildClientExtension(); } } diff --git a/tests/Splitio.TestSupport/SplitClientForTest.cs b/tests/Splitio.TestSupport/SplitClientForTest.cs index 8c29c458..12db14b9 100644 --- a/tests/Splitio.TestSupport/SplitClientForTest.cs +++ b/tests/Splitio.TestSupport/SplitClientForTest.cs @@ -8,8 +8,9 @@ public class SplitClientForTest : SplitClient { private readonly Dictionary _tests; - public SplitClientForTest(ConfigurationOptions config) : base("SplitClientForTest", config.Mode) + public SplitClientForTest(ConfigurationOptions config) : base("SplitClientForTest") { + BuildEventsManager(); BuildFallbackCalculator(config.FallbackTreatments); _tests = new Dictionary(); } diff --git a/tests/Splitio.Tests.Common/BaseAsyncClientTests.cs b/tests/Splitio.Tests.Common/BaseAsyncClientTests.cs index cf6f7ebf..7f39012a 100644 --- a/tests/Splitio.Tests.Common/BaseAsyncClientTests.cs +++ b/tests/Splitio.Tests.Common/BaseAsyncClientTests.cs @@ -984,7 +984,7 @@ public async Task TrackAsync_WithValidData_ReturnsTrue() new EventBackend { Key = "key_4", TrafficTypeName = "traffic_type_4", EventTypeId = "event_type_4", Value = 444, Properties = properties } }; - var apikey = "base-apikey17"; + var apikey = "base-apikey20"; var splitFactory = new SplitFactory(apikey, configurations); var client = splitFactory.Client(); @@ -1001,6 +1001,7 @@ public async Task TrackAsync_WithValidData_ReturnsTrue() } //Validate Events sent to the be. + await Task.Delay(1000); AssertSentEvents(events); await client.DestroyAsync(); } @@ -1042,6 +1043,7 @@ public async Task TrackAsync_WithBUR_ReturnsTrue() } //Validate Events sent to the be. + await Task.Delay(1000); AssertSentEvents(events); await client.DestroyAsync(); } @@ -1091,6 +1093,7 @@ public async Task TrackAsync_WithInvalidData_ReturnsFalse() .ToList(); //Validate Events sent to the be. + await Task.Delay(1000); AssertSentEvents(events); await client.DestroyAsync(); } From 0474728f65cafaa5a3054ac125eda5bed27f8b1b Mon Sep 17 00:00:00 2001 From: Bill Al Date: Tue, 3 Mar 2026 14:15:52 -0800 Subject: [PATCH 3/8] polish --- Splitio.Redis/Services/Client/Classes/RedisClient.cs | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/Splitio.Redis/Services/Client/Classes/RedisClient.cs b/Splitio.Redis/Services/Client/Classes/RedisClient.cs index 88c0b16a..886cb4ef 100644 --- a/Splitio.Redis/Services/Client/Classes/RedisClient.cs +++ b/Splitio.Redis/Services/Client/Classes/RedisClient.cs @@ -36,9 +36,7 @@ public RedisClient(ConfigurationOptions config, string apiKey) : base(apiKey) ReadConfig(config); - _eventsManager = null; - _internalEventsTask = new NoOpInternalEventsTask(); -// BuildEventsManager(); + BuildEventsManager(); BuildStatusAndTaskManager(); BuildFallbackCalculator(_config.FallbackTreatments); BuildRedisCache(); From 325390ff6665cf76ae77f8d69c0d4045acf6998e Mon Sep 17 00:00:00 2001 From: Bill Al Date: Thu, 5 Mar 2026 10:20:25 -0800 Subject: [PATCH 4/8] polishing --- Splitio.Redis/Services/Client/Classes/RedisClient.cs | 8 ++++---- src/Splitio/Services/Cache/Classes/InMemorySplitCache.cs | 2 +- src/Splitio/Services/Client/Classes/SplitClient.cs | 3 ++- src/Splitio/Services/Tasks/NoOpInternalEventsTask.cs | 9 ++++++--- 4 files changed, 13 insertions(+), 9 deletions(-) diff --git a/Splitio.Redis/Services/Client/Classes/RedisClient.cs b/Splitio.Redis/Services/Client/Classes/RedisClient.cs index 886cb4ef..bd65ac25 100644 --- a/Splitio.Redis/Services/Client/Classes/RedisClient.cs +++ b/Splitio.Redis/Services/Client/Classes/RedisClient.cs @@ -36,7 +36,7 @@ public RedisClient(ConfigurationOptions config, string apiKey) : base(apiKey) ReadConfig(config); - BuildEventsManager(); + BuildRedisEventsManager(); BuildStatusAndTaskManager(); BuildFallbackCalculator(_config.FallbackTreatments); BuildRedisCache(); @@ -57,14 +57,14 @@ public RedisClient(ConfigurationOptions config, string apiKey) : base(apiKey) _syncManager.Start(); } - - override protected void BuildEventsManager() + + #region Private Methods + private void BuildRedisEventsManager() { _eventsManager = null; _internalEventsTask = new NoOpInternalEventsTask(); } - #region Private Methods private void ReadConfig(ConfigurationOptions config) { var baseConfig = _configService.ReadConfig(config, ConfigTypes.Redis); diff --git a/src/Splitio/Services/Cache/Classes/InMemorySplitCache.cs b/src/Splitio/Services/Cache/Classes/InMemorySplitCache.cs index 6063d43e..8b637808 100644 --- a/src/Splitio/Services/Cache/Classes/InMemorySplitCache.cs +++ b/src/Splitio/Services/Cache/Classes/InMemorySplitCache.cs @@ -78,7 +78,7 @@ public void Update(List toAdd, List toRemove, long till) } SetChangeNumber(till); - if (eventsFlags.Any()) + if (eventsFlags.Count > 0) { Task task = new Task(() => { diff --git a/src/Splitio/Services/Client/Classes/SplitClient.cs b/src/Splitio/Services/Client/Classes/SplitClient.cs index f719150b..0910e8d4 100644 --- a/src/Splitio/Services/Client/Classes/SplitClient.cs +++ b/src/Splitio/Services/Client/Classes/SplitClient.cs @@ -458,12 +458,13 @@ protected void BuildFallbackCalculator(FallbackTreatmentsConfiguration fallbackT _fallbackTreatmentCalculator = new FallbackTreatmentCalculator(fallbackTreatmentsConfiguration); } - protected virtual void BuildEventsManager() + protected void BuildEventsManager() { _eventsManager = new EventsManager(new EventsManagerConfig(), new EventDelivery()); _internalEventsTask = new InternalEventsTask(_eventsManager, new SplitQueue()); _internalEventsTask.Start(); RegisterEvents(); + _configMode = Mode.Standalone; } #endregion diff --git a/src/Splitio/Services/Tasks/NoOpInternalEventsTask.cs b/src/Splitio/Services/Tasks/NoOpInternalEventsTask.cs index 938130c0..03011566 100644 --- a/src/Splitio/Services/Tasks/NoOpInternalEventsTask.cs +++ b/src/Splitio/Services/Tasks/NoOpInternalEventsTask.cs @@ -10,10 +10,13 @@ public NoOpInternalEventsTask() return; } public async Task AddToQueue(SdkInternalEvent sdkInternalEvent, EventMetadata eventMetadata) - { return; } + { await DoNothing(); } - public void Start() { return; } + public void Start() { } - public void Stop() { return; } + public void Stop() { } + + public Task DoNothing() + { return Task.FromResult(true); } } } From b82a7ab27498e627b09d269c9ea843c7b8449b95 Mon Sep 17 00:00:00 2001 From: Bill Al Date: Thu, 5 Mar 2026 10:46:23 -0800 Subject: [PATCH 5/8] polish --- src/Splitio/Services/Tasks/NoOpInternalEventsTask.cs | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/src/Splitio/Services/Tasks/NoOpInternalEventsTask.cs b/src/Splitio/Services/Tasks/NoOpInternalEventsTask.cs index 03011566..1410df79 100644 --- a/src/Splitio/Services/Tasks/NoOpInternalEventsTask.cs +++ b/src/Splitio/Services/Tasks/NoOpInternalEventsTask.cs @@ -5,10 +5,7 @@ namespace Splitio.Services.Tasks { public class NoOpInternalEventsTask : IInternalEventsTask { - public NoOpInternalEventsTask() - { - return; - } + public NoOpInternalEventsTask() {} public async Task AddToQueue(SdkInternalEvent sdkInternalEvent, EventMetadata eventMetadata) { await DoNothing(); } @@ -16,7 +13,7 @@ public void Start() { } public void Stop() { } - public Task DoNothing() + public static Task DoNothing() { return Task.FromResult(true); } } } From a485d535b9af7972d041ad5d374135f0047db403 Mon Sep 17 00:00:00 2001 From: Bill Al Date: Thu, 5 Mar 2026 11:49:58 -0800 Subject: [PATCH 6/8] polish --- src/Splitio/Services/Client/Classes/SplitClient.cs | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/src/Splitio/Services/Client/Classes/SplitClient.cs b/src/Splitio/Services/Client/Classes/SplitClient.cs index 0910e8d4..17910ad0 100644 --- a/src/Splitio/Services/Client/Classes/SplitClient.cs +++ b/src/Splitio/Services/Client/Classes/SplitClient.cs @@ -66,7 +66,6 @@ public abstract class SplitClient : ISplitClient protected IEventsManager _eventsManager; protected IInternalEventsTask _internalEventsTask; private EventHandler SdkReadyEvent; - private Mode _configMode; public event EventHandler SdkReady { @@ -464,7 +463,6 @@ protected void BuildEventsManager() _internalEventsTask = new InternalEventsTask(_eventsManager, new SplitQueue()); _internalEventsTask.Start(); RegisterEvents(); - _configMode = Mode.Standalone; } #endregion @@ -534,11 +532,8 @@ private void RegisterEvents() } private void UnregisterEvents() { - if (_configMode == Mode.Standalone) - { - _eventsManager.Unregister(SdkEvent.SdkReady); - _eventsManager.Unregister(SdkEvent.SdkUpdate); - } + _eventsManager.Unregister(SdkEvent.SdkReady); + _eventsManager.Unregister(SdkEvent.SdkUpdate); } private List GetTreatmentsSync(Enums.API method, Key key, List features, Dictionary attributes = null, EvaluationOptions evaluationOptions = null) { From a93c9a297753a32322a86a5fe49a00f3cdb619d9 Mon Sep 17 00:00:00 2001 From: Bill Al Date: Thu, 5 Mar 2026 12:43:10 -0800 Subject: [PATCH 7/8] update version to rc5 --- Splitio.Redis/Splitio.Redis.csproj | 2 +- src/Splitio/Splitio.csproj | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/Splitio.Redis/Splitio.Redis.csproj b/Splitio.Redis/Splitio.Redis.csproj index ed6c646d..56e7e0a3 100644 --- a/Splitio.Redis/Splitio.Redis.csproj +++ b/Splitio.Redis/Splitio.Redis.csproj @@ -7,7 +7,7 @@ false false false - 7.13.0-rc2 + 7.13.0-rc5 true SplitioRedis.snk Apache-2.0 diff --git a/src/Splitio/Splitio.csproj b/src/Splitio/Splitio.csproj index 8f059f77..7070ef19 100644 --- a/src/Splitio/Splitio.csproj +++ b/src/Splitio/Splitio.csproj @@ -7,7 +7,7 @@ false false false - 7.13.0-rc2 + 7.13.0-rc5 Splitio true Splitio.snk From 9861755dda82dbb87d997907dc3f875c9ae963e9 Mon Sep 17 00:00:00 2001 From: Bill Al Date: Mon, 9 Mar 2026 13:25:49 -0700 Subject: [PATCH 8/8] remove task delays --- tests/Splitio.Tests.Common/BaseAsyncClientTests.cs | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/tests/Splitio.Tests.Common/BaseAsyncClientTests.cs b/tests/Splitio.Tests.Common/BaseAsyncClientTests.cs index 7f39012a..47724179 100644 --- a/tests/Splitio.Tests.Common/BaseAsyncClientTests.cs +++ b/tests/Splitio.Tests.Common/BaseAsyncClientTests.cs @@ -1001,7 +1001,7 @@ public async Task TrackAsync_WithValidData_ReturnsTrue() } //Validate Events sent to the be. - await Task.Delay(1000); +// await Task.Delay(1000); AssertSentEvents(events); await client.DestroyAsync(); } @@ -1043,7 +1043,7 @@ public async Task TrackAsync_WithBUR_ReturnsTrue() } //Validate Events sent to the be. - await Task.Delay(1000); +// await Task.Delay(1000); AssertSentEvents(events); await client.DestroyAsync(); } @@ -1093,7 +1093,7 @@ public async Task TrackAsync_WithInvalidData_ReturnsFalse() .ToList(); //Validate Events sent to the be. - await Task.Delay(1000); +// await Task.Delay(1000); AssertSentEvents(events); await client.DestroyAsync(); } @@ -1138,7 +1138,7 @@ public async Task TrackAsync_WithLowQueue_ReturnsTrue() } //Validate Events sent to the be. - await Task.Delay(1000); +// await Task.Delay(1000); AssertSentEvents(events, eventsCount: 3, validateEvents: false); await client.DestroyAsync(); }