diff --git a/composer.json b/composer.json index bf888a81..d4226385 100644 --- a/composer.json +++ b/composer.json @@ -54,7 +54,7 @@ "cs-check": "phpcs -p -s --standard=vendor/spryker/code-sniffer/Spryker/ruleset.xml --ignore=/tests/app/ src/ tests/", "cs-fix": "phpcbf -p --standard=vendor/spryker/code-sniffer/Spryker/ruleset.xml --ignore=/tests/app/ src/ tests/", "stan": "phpstan analyse", - "stan-setup": "cp composer.json composer.backup && composer require --dev phpstan/phpstan:^1.0.0 && mv composer.backup composer.json", + "stan-setup": "cp composer.json composer.backup && composer require --dev phpstan/phpstan:^2.1.0 && mv composer.backup composer.json", "test": "codecept build && codecept run" }, "extra": { diff --git a/phpstan.neon b/phpstan.neon index b3cac781..9e6e4a36 100644 --- a/phpstan.neon +++ b/phpstan.neon @@ -2,15 +2,16 @@ parameters: level: 8 paths: - src/ - checkMissingIterableValueType: false excludePaths: - '*/templates/*' - - 'src/Spryker/Zed/EventBehavior/Persistence/Propel/AbstractSpyEventBehaviorEntityChange.php' - - 'src/Spryker/Zed/EventBehavior/Persistence/Propel/AbstractSpyEventBehaviorEntityChangeQuery.php' + - 'src/Spryker/Zed/EventBehavior/Persistence/Propel/AbstractSpyEventBehaviorEntityChange.php (?)' + - 'src/Spryker/Zed/EventBehavior/Persistence/Propel/AbstractSpyEventBehaviorEntityChangeQuery.php (?)' ignoreErrors: - '#Parameter \#1 \$plugins of method .+EventResourceQueryContainerManager::processResourceEvents\(\) expects .+ given.#' - '#Call to (static method|method) .+ on an unknown class Generated\\.+#' - '#Cannot call method offset\(\) on .+ModelCriteria\|null#' - '#Parameter \#1 \$clause of method .+\\ModelCriteria::where\(\) expects array\|literal-string, non-falsy-string given.#' + - + identifier: missingType.iterableValue bootstrapFiles: - tests/bootstrap.php diff --git a/src/Spryker/Glue/EventBehavior/Plugin/EventDispatcher/EventBehaviorEventDispatcherPlugin.php b/src/Spryker/Glue/EventBehavior/Plugin/EventDispatcher/EventBehaviorEventDispatcherPlugin.php index 42263356..449e30c1 100644 --- a/src/Spryker/Glue/EventBehavior/Plugin/EventDispatcher/EventBehaviorEventDispatcherPlugin.php +++ b/src/Spryker/Glue/EventBehavior/Plugin/EventDispatcher/EventBehaviorEventDispatcherPlugin.php @@ -14,7 +14,6 @@ use Symfony\Component\HttpKernel\KernelEvents; /** - * @method \Spryker\Glue\EventBehavior\EventBehaviorDependencyFactory getFactory() * @method \Spryker\Zed\EventBehavior\Business\EventBehaviorFacadeInterface getFacade() */ class EventBehaviorEventDispatcherPlugin extends AbstractPlugin implements EventDispatcherPluginInterface diff --git a/src/Spryker/Zed/EventBehavior/Business/Model/AbstractEventResourcePluginIterator.php b/src/Spryker/Zed/EventBehavior/Business/Model/AbstractEventResourcePluginIterator.php index 0008b280..e02cb3ee 100644 --- a/src/Spryker/Zed/EventBehavior/Business/Model/AbstractEventResourcePluginIterator.php +++ b/src/Spryker/Zed/EventBehavior/Business/Model/AbstractEventResourcePluginIterator.php @@ -88,7 +88,7 @@ public function key(): int */ public function valid(): bool { - return is_array($this->current) && $this->current !== []; + return is_array($this->current) && $this->current !== []; // @phpstan-ignore function.alreadyNarrowedType } /** diff --git a/src/Spryker/Zed/EventBehavior/Business/Model/EventEntityTransferFilter.php b/src/Spryker/Zed/EventBehavior/Business/Model/EventEntityTransferFilter.php index 1f094b8a..7302e59f 100644 --- a/src/Spryker/Zed/EventBehavior/Business/Model/EventEntityTransferFilter.php +++ b/src/Spryker/Zed/EventBehavior/Business/Model/EventEntityTransferFilter.php @@ -47,7 +47,7 @@ public function getEventTransferForeignKeys(array $eventTransfers, $foreignKeyCo } $value = $eventTransfer->getForeignKeys()[$foreignKeyColumnName]; - if ($value !== null) { + if ($value !== null) { // @phpstan-ignore notIdentical.alwaysTrue $foreignKeys[] = $value; } } diff --git a/src/Spryker/Zed/EventBehavior/Communication/Console/EventTriggerConsole.php b/src/Spryker/Zed/EventBehavior/Communication/Console/EventTriggerConsole.php index c075bfc4..0581d266 100644 --- a/src/Spryker/Zed/EventBehavior/Communication/Console/EventTriggerConsole.php +++ b/src/Spryker/Zed/EventBehavior/Communication/Console/EventTriggerConsole.php @@ -98,8 +98,7 @@ protected function execute(InputInterface $input, OutputInterface $output): int if ($input->getOption(static::RESOURCE_IDS_OPTION)) { /** @var string $idsString */ $idsString = $input->getOption(static::RESOURCE_IDS_OPTION); - /** @var array $resourcesIds */ - $resourcesIds = explode(',', $idsString); + $resourcesIds = array_map('intval', explode(',', $idsString)); } $this->getFacade()->executeResolvedPluginsBySources($resources, $resourcesIds);