forked from JhaSourav07/commitpulse
-
Notifications
You must be signed in to change notification settings - Fork 0
Expand file tree
/
Copy pathmiddleware.test.ts
More file actions
422 lines (336 loc) · 12.9 KB
/
Copy pathmiddleware.test.ts
File metadata and controls
422 lines (336 loc) · 12.9 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
import { beforeEach, afterEach, describe, expect, it, vi } from 'vitest';
import { NextRequest, NextResponse } from 'next/server';
import { middleware, config } from './middleware';
import { rateLimit } from '@/lib/rate-limit';
vi.mock('@/lib/rate-limit', () => ({
rateLimit: vi.fn(),
}));
function mockBothLimiters(
refreshResult: Awaited<ReturnType<typeof rateLimit>>,
generalSuccess = true
) {
vi.mocked(rateLimit).mockResolvedValueOnce(refreshResult).mockResolvedValueOnce({
success: generalSuccess,
limit: 60,
remaining: 59,
reset: 123456789,
});
}
describe('middleware', () => {
let originalEnv: string | undefined;
beforeEach(() => {
vi.clearAllMocks();
originalEnv = process.env.TRUSTED_PROXIES;
process.env.TRUSTED_PROXIES = '5.6.7.8, 9.10.11.12';
});
afterEach(() => {
process.env.TRUSTED_PROXIES = originalEnv;
});
it('calls NextResponse.next when rate limit succeeds', async () => {
vi.mocked(rateLimit).mockResolvedValue({
success: true,
limit: 60,
remaining: 59,
reset: 123456789,
});
const nextSpy = vi.spyOn(NextResponse, 'next');
const request = new NextRequest('http://localhost:3000/api/streak?user=octocat');
await middleware(request);
expect(nextSpy).toHaveBeenCalled();
});
it('returns 429 when rate limit fails', async () => {
vi.mocked(rateLimit).mockResolvedValue({
success: false,
limit: 60,
remaining: 0,
reset: 123456789,
});
const request = new NextRequest('http://localhost:3000/api/streak?user=octocat');
const response = await middleware(request);
expect(response.status).toBe(429);
});
it('returns too many requests error body when rate limit fails', async () => {
vi.mocked(rateLimit).mockResolvedValue({
success: false,
limit: 60,
remaining: 0,
reset: 123456789,
});
const request = new NextRequest('http://localhost:3000/api/streak?user=octocat');
const response = await middleware(request);
await expect(response.json()).resolves.toEqual({
error: 'Too many requests',
});
});
it('calls rateLimit with fixed policy values (60 requests / 60000ms) for normal requests', async () => {
vi.mocked(rateLimit).mockResolvedValue({
success: true,
limit: 60,
remaining: 59,
reset: 123456789,
});
const request = new NextRequest('http://localhost:3000/api/streak?user=octocat');
await middleware(request);
expect(rateLimit).toHaveBeenCalledWith(expect.any(String), 60, 60000);
});
it('sets all X-RateLimit headers on successful requests', async () => {
vi.mocked(rateLimit).mockResolvedValue({
success: true,
limit: 60,
remaining: 59,
reset: 123456789,
});
const request = new NextRequest('http://localhost:3000/api/streak?user=octocat');
const response = await middleware(request);
expect(response.headers.get('X-RateLimit-Limit')).toBe('60');
expect(response.headers.get('X-RateLimit-Remaining')).toBe('59');
expect(response.headers.get('X-RateLimit-Reset')).toBe('123456789');
});
it('keeps headers present on the returned response object (regression)', async () => {
vi.mocked(rateLimit).mockResolvedValue({
success: true,
limit: 60,
remaining: 58,
reset: 111,
});
const request = new NextRequest('http://localhost:3000/api/streak?user=octocat');
const response = await middleware(request);
expect(response.headers.get('X-RateLimit-Limit')).toBe('60');
expect(response.headers.get('X-RateLimit-Remaining')).toBe('58');
expect(response.headers.get('X-RateLimit-Reset')).toBe('111');
});
it('sets JSON and rate headers on throttled responses', async () => {
vi.mocked(rateLimit).mockResolvedValue({
success: false,
limit: 60,
remaining: 0,
reset: 123456789,
});
const request = new NextRequest('http://localhost:3000/api/streak?user=octocat');
const response = await middleware(request);
expect(response.headers.get('Content-Type')).toBe('application/json');
expect(response.headers.get('X-RateLimit-Limit')).toBe('60');
expect(response.headers.get('X-RateLimit-Remaining')).toBe('0');
expect(response.headers.get('X-RateLimit-Reset')).toBe('123456789');
});
it('uses first IP from x-forwarded-for when subsequent hops are trusted', async () => {
vi.mocked(rateLimit).mockResolvedValue({
success: true,
limit: 60,
remaining: 59,
reset: 123456789,
});
const request = new NextRequest('http://localhost:3000/api/streak?user=octocat', {
headers: {
'x-forwarded-for': '1.2.3.4, 5.6.7.8',
},
});
await middleware(request);
expect(rateLimit).toHaveBeenCalledWith('1.2.3.4', 60, 60000);
});
it('ignores spoofed x-forwarded-for when subsequent hops are untrusted', async () => {
vi.mocked(rateLimit).mockResolvedValue({
success: true,
limit: 60,
remaining: 59,
reset: 123456789,
});
process.env.TRUSTED_PROXIES = '';
const request = new NextRequest('http://localhost:3000/api/streak?user=octocat', {
headers: {
'x-forwarded-for': '1.2.3.4, 5.6.7.8',
},
});
await middleware(request);
expect(rateLimit).toHaveBeenCalledWith('5.6.7.8', 60, 60000);
});
it('uses x-real-ip if x-forwarded-for is missing', async () => {
vi.mocked(rateLimit).mockResolvedValue({
success: true,
limit: 60,
remaining: 59,
reset: 123456789,
});
const request = new NextRequest('http://localhost:3000/api/streak?user=octocat', {
headers: {
'x-real-ip': '9.9.9.9',
},
});
await middleware(request);
expect(rateLimit).toHaveBeenCalledWith('9.9.9.9', 60, 60000);
});
it('defaults to 127.0.0.1 when no IP headers', async () => {
vi.mocked(rateLimit).mockResolvedValue({
success: true,
limit: 60,
remaining: 59,
reset: 123456789,
});
const request = new NextRequest('http://localhost:3000/api/streak?user=octocat');
await middleware(request);
expect(rateLimit).toHaveBeenCalledWith('127.0.0.1', 60, 60000);
});
it('prefers x-forwarded-for over x-real-ip', async () => {
vi.mocked(rateLimit).mockResolvedValue({
success: true,
limit: 60,
remaining: 59,
reset: 123456789,
});
const request = new NextRequest('http://localhost:3000/api/streak?user=octocat', {
headers: {
'x-forwarded-for': '1.2.3.4, 5.6.7.8',
'x-real-ip': '9.9.9.9',
},
});
await middleware(request);
expect(rateLimit).toHaveBeenCalledWith('1.2.3.4', 60, 60000);
});
it('handles multiple IPs with whitespace', async () => {
vi.mocked(rateLimit).mockResolvedValue({
success: true,
limit: 60,
remaining: 59,
reset: 123456789,
});
const request = new NextRequest('http://localhost:3000/api/streak?user=octocat', {
headers: {
'x-forwarded-for': '1.2.3.4, 5.6.7.8, 9.10.11.12',
},
});
await middleware(request);
expect(rateLimit).toHaveBeenCalledWith('1.2.3.4', 60, 60000);
});
it('includes compare API matcher in proxy config', () => {
expect(config.matcher).toContain('/api/compare/:path*');
});
it('includes wrapped and student API matchers in proxy config', () => {
expect(config.matcher).toContain('/api/wrapped/:path*');
expect(config.matcher).toContain('/api/student/:path*');
});
describe('?refresh=true cache-bypass rate limit', () => {
it('applies the refresh limiter (5 req/min) before the general limiter', async () => {
mockBothLimiters({ success: true, limit: 5, remaining: 4, reset: 123456789 });
const request = new NextRequest('http://localhost:3000/api/streak?user=octocat&refresh=true');
await middleware(request);
expect(rateLimit).toHaveBeenNthCalledWith(1, 'refresh:127.0.0.1', 5, 60000);
expect(rateLimit).toHaveBeenNthCalledWith(2, '127.0.0.1', 60, 60000);
});
it('returns 429 with refresh-specific message when refresh limit is exceeded', async () => {
mockBothLimiters({ success: false, limit: 5, remaining: 0, reset: 123456789 });
const request = new NextRequest('http://localhost:3000/api/streak?user=octocat&refresh=true');
const response = await middleware(request);
expect(response.status).toBe(429);
const body = await response.json();
expect(body.error).toContain('refresh');
});
it('response limit header is 5 (not 60) when the refresh rate limit is exceeded', async () => {
vi.mocked(rateLimit).mockResolvedValueOnce({
success: false,
limit: 5,
remaining: 0,
reset: 123456789,
});
const request = new NextRequest('http://localhost:3000/api/streak?user=octocat&refresh=true');
const response = await middleware(request);
expect(response.headers.get('X-RateLimit-Limit')).toBe('5');
expect(response.status).toBe(429);
});
it('does NOT invoke the general limiter when the refresh limit is exceeded', async () => {
vi.mocked(rateLimit).mockResolvedValueOnce({
success: false,
limit: 5,
remaining: 0,
reset: 123456789,
});
const request = new NextRequest('http://localhost:3000/api/streak?user=octocat&refresh=true');
await middleware(request);
expect(rateLimit).not.toHaveBeenCalledWith('127.0.0.1', 60, 60000);
});
it('sets X-RateLimit-Limit to 5 on a blocked refresh request', async () => {
vi.mocked(rateLimit).mockResolvedValueOnce({
success: false,
limit: 5,
remaining: 0,
reset: 999999,
});
const request = new NextRequest('http://localhost:3000/api/streak?user=octocat&refresh=true');
const response = await middleware(request);
expect(response.headers.get('X-RateLimit-Limit')).toBe('5');
expect(response.headers.get('X-RateLimit-Remaining')).toBe('0');
});
it('skips the refresh limiter when refresh param is absent', async () => {
vi.mocked(rateLimit).mockResolvedValue({
success: true,
limit: 60,
remaining: 59,
reset: 123456789,
});
const request = new NextRequest('http://localhost:3000/api/streak?user=octocat');
await middleware(request);
expect(rateLimit).toHaveBeenCalledTimes(1);
expect(rateLimit).toHaveBeenCalledWith('127.0.0.1', 60, 60000);
});
it('skips the refresh limiter when refresh=false', async () => {
vi.mocked(rateLimit).mockResolvedValue({
success: true,
limit: 60,
remaining: 59,
reset: 123456789,
});
const request = new NextRequest(
'http://localhost:3000/api/streak?user=octocat&refresh=false'
);
await middleware(request);
expect(rateLimit).toHaveBeenCalledTimes(1);
expect(rateLimit).not.toHaveBeenCalledWith(expect.stringContaining('refresh:'), 5, 60000);
});
it('still applies general limiter when refresh succeeds', async () => {
mockBothLimiters({ success: true, limit: 5, remaining: 3, reset: 123456789 });
const request = new NextRequest('http://localhost:3000/api/streak?user=octocat&refresh=true');
const response = await middleware(request);
expect(rateLimit).toHaveBeenCalledTimes(2);
expect(response.status).toBe(200);
});
it('returns 429 from general limiter even when refresh succeeds', async () => {
vi.mocked(rateLimit)
.mockResolvedValueOnce({ success: true, limit: 5, remaining: 2, reset: 123456789 })
.mockResolvedValueOnce({ success: false, limit: 60, remaining: 0, reset: 123456789 });
const request = new NextRequest('http://localhost:3000/api/streak?user=octocat&refresh=true');
const response = await middleware(request);
expect(response.status).toBe(429);
const body = await response.json();
expect(body.error).toBe('Too many requests');
});
});
});
describe('middleware.ts wiring', () => {
it('middleware.ts exports a function named middleware', async () => {
const mod = await import('./middleware');
// Next.js looks for a named export called `middleware`
expect(typeof mod.middleware).toBe('function');
});
it('middleware.ts exports config with a non-empty matcher array', async () => {
const mod = await import('./middleware');
expect(mod.config).toBeDefined();
expect(Array.isArray(mod.config.matcher)).toBe(true);
expect(mod.config.matcher.length).toBeGreaterThan(0);
});
it('middleware covers all expected API routes', async () => {
const { config: mwConfig } = await import('./middleware');
const expected = [
'/api/streak/:path*',
'/api/github/:path*',
'/api/track-user/:path*',
'/api/stats/:path*',
'/api/og/:path*',
'/api/notify/:path*',
'/api/compare/:path*',
'/api/wrapped/:path*',
'/api/student/:path*',
];
for (const route of expected) {
expect(mwConfig.matcher).toContain(route);
}
});
});