Skip to content

Explore how to make creating a new RPC Client more flexible #17

Description

@elizabethengelman

While implementing stellar/stellar-cli#1583 (CLI should support rpc providers which require an API key) we discovered that we needed to rework how we're creating new rpc clients so that we could allow users to pass in custom HTTP headers. The change made as part of #1583 is not very flexible if a user needs to change more than just the headers.

We should design a more flexible way to create rpc clients that allow for more customization. A couple of suggestions were:

  • use the builder pattern
  • allow a user to pass in an HttpClient

Based on these discussions:

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions