feat: implement RBAC with roles guard and decorator, fix transactions…#51
Merged
Merged
Conversation
Contributor
|
@Yilkash resolve conflict |
Contributor
Author
|
@Uyoxy PR resolved |
Contributor
|
your check is failing kindly fix it |
Contributor
Author
|
@Uyoxy I was about doing that and you closed the issue , i did not get any point on this issue, it is showing under review |
Contributor
|
@Yilkash it was a mix up please proceed |
Contributor
Author
|
@Uyoxy all issues fixed and resolved |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
close #17
Branch:
feature/rbac-implementationDescription
Implements Role-Based Access Control (RBAC) to secure administrative endpoints and fixes critical syntax errors in the
TransactionsModule.Changes
src/common/guards/roles.guard.ts- Guard to check user roles.src/modules/auth/roles.decorator.ts-@Roles()decorator.src/modules/users/user.entity.ts- Addedrolecolumn andUserRoleenum.src/modules/admin/admin.controller.ts- Secured endpoints with@Roles(UserRole.ADMIN).src/modules/transactions/transactions.module.ts- Fixed syntax errors (duplicate decorators and misplaced imports).Verification
RolesGuardcorrectly pulls user roles from the request object for authorization.