Skip to content

Stub limit parameter in gRPC connector (crates/connectors) #3

Description

@banickn

Context: In crates/connectors/src/sources/grpc.rs (around line 222), there is a TODO: Implement limit pushdown. While full limit pushdown requires translating the DataFusion logical plan into the specific gRPC request message, the first step is just to plumb the limit: Option<usize> through the source definition.

Task:

  1. Locate crates/connectors/src/sources/grpc.rs.
  2. Find where the limit might be passed into the connector (usually in the scan method of TableProvider).
  3. Add a tracing::debug!("gRPC connector limit pushdown requested: {:?}", limit); to acknowledge the limit parameter is received, removing the TODO comment.
    This prepares the scaffolding for the actual pushdown implementation later.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions