Deprecation warnings caused by node-byline dependency

[mistic]

@rmg @sam-github On node 10 I'm having deprecation warnings using strong-log-transformer due to it's node-byline dependency usage of the node Buffer api. I've already opened a PR against node-byline (jahewson/node-byline#53) in order to fix those problems, but the library seems to be very unmaintained so far, so I don't think if the PR will ever get merged and released.

In case that happens it might be a good idea try to replace this node-byline with other with the same needed features.

[rmg]

@mistic thanks for the heads up. I'll see what I can find.

[rmg]

@mistic are you using strong-log-transformer directly? Or is it pulled in by something you use? Just trying to get a feel for how best to make sure #8 doesn't break anything.

[mistic]

@rmg I'm using it directly right here: https://github.com/elastic/kibana/blob/7a2627797f05f8b0e397c5d13f8d76194064b43c/packages/kbn-pm/src/utils/child_process.ts#L55

[rmg]

Cool, thanks for the link. After I posted I did a little searching and was happy to see several uses outside of the original strong-supervisor usage.

It looks like your usage pattern is the most common one. I'll add some ANSI escape codes to some tests to make sure that colourizing things is treated as first-class usage.

[mistic]

@rmg thank you very much for taking care of this!

[rmg]

@mistic published as strong-log-transformer@2.1.0 with only the additional tests and the byline replacement to keep things conservative.

[mistic]

@rmg thank you very much for the quick fix on this!