Skip to content

catching blank tables, rows and cells #21

@wolispace

Description

@wolispace

I have made a few hacks to my old v2 sortable.js and just found this v2e3 (thanks for the great work).

The hacks needed to re-do are:

line 85:

guessType: function(table, column, sortle) {
		
  // ADD WM 2014-07-28 - if there are no rows in the tbody then return..
  if (!table.tBodies[0]) {
    return;
  }

line 164:

getInnerText: function(node) {
...  
  // wm 20170520 - ignore Comment nodes - we can tell them as they have a nodeType==8..
  if (!node || node.nodeType == 8) {
   return '';
  }

I can't remember why I needed to ignore nodeType==8 but checking for no node was rather important (I think with rows with no where expected, colspan=2 etc..)

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions