Skip to content

Test coverage: Rescan doesn't add duplicate request id to Record #1

Description

@tynes

I think the current implementation of the Records will allow for duplicate request ids being added to the requests array.

Possible fixes:

  • Make requests into a Set instead of an array
  • Add hasRequestId method to the records and check that function before inserting a request id into the requests property

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions