Fix converter for old jsons

Author: dshabin

superannotate/input_converters/converters/coco_converters/coco_converter.py

@@ -18,6 +18,8 @@
 
 class CocoBaseStrategy(baseStrategy):
     project_type_to_json_ending = {
+        'Pixel': '___pixel.json',
+        'Vector': '___objects.json',
         'pixel': '___pixel.json',
         'vector': '___objects.json'
     }
@@ -169,11 +171,10 @@ def _parse_json_into_common_format(self, sa_annotation_json, fpath):
 
         if 'name' not in sa_annotation_json[
             'metadata'] or sa_annotation_json['metadata']['name'] is None:
-            fname = fpath.split('/')[-1]
+            fname = fpath.name
             fname = fname[:-len(
                 self.project_type_to_json_ending[self.project_type]
             )]
-
             sa_annotation_json['metadata']['name'] = fname
         sa_annotation_json['metadata']['image_path'] = str(
             Path(fpath).parent / sa_annotation_json['metadata']['name']

tests/converter_test/COCO/input/fromSuperAnnotate/vector_no_name/classes/classes.json

@@ -0,0 +1 @@
+[{"id":599064,"project_id":76203,"name":"some","color":"#c444de","count":0,"createdAt":"2021-05-04T07:26:32.000Z","updatedAt":"2021-05-04T07:26:32.000Z","attribute_groups":[]}]

tests/converter_test/COCO/input/fromSuperAnnotate/vector_no_name/t.png

@@ -0,0 +1,50 @@
+{
+    "metadata": {
+        "lastAction": {
+            "email": "",
+            "timestamp": 1621320107809
+        },
+        "width": 1234,
+        "height": 1540,
+        "projectId": 76203,
+        "isPredicted": false,
+        "status": "Completed",
+        "pinned": false,
+        "annotatorEmail": null,
+        "qaEmail": null
+    },
+    "comments": [],
+    "tags": [],
+    "instances": [
+        {
+            "type": "bbox",
+            "classId": 599064,
+            "probability": 100,
+            "points": {
+                "x1": 312.52,
+                "x2": 1053.63,
+                "y1": 291.08,
+                "y2": 1405.83
+            },
+            "groupId": 0,
+            "pointLabels": {},
+            "locked": false,
+            "visible": true,
+            "attributes": [],
+            "trackingId": null,
+            "error": null,
+            "createdAt": "2021-05-18T06:41:55.965Z",
+            "createdBy": {
+                "email": "",
+                "role": "Admin"
+            },
+            "creationType": "Manual",
+            "updatedAt": "2021-05-18T06:42:30.415Z",
+            "updatedBy": {
+                "email": "",
+                "role": "Admin"
+            },
+            "className": "some"
+        }
+    ]
+}

tests/converter_test/COCO/input/fromSuperAnnotate/vector_no_name/t.png___fuse.png

@@ -113,3 +113,14 @@ def test_instance_segmentation_sa2coco_vector_empty_array(tmpdir):
     with open(truth_path, 'r') as f:
         truth = json.loads(f.read())
     assert truth == data
+
+
+def test_instance_segmentation_sa2coco_vector_empty_name(tmpdir):
+    input_dir = Path(
+        "tests"
+    ) / "converter_test" / "COCO" / "input" / "fromSuperAnnotate" / "vector_no_name"
+    out_path = Path("sssss1") / "fromSuperAnnotate" / "instance_test_vector"
+    sa.export_annotation(
+        input_dir, out_path, "COCO", "instance_test_vector", "Vector",
+        "instance_segmentation"
+    )