Remove image upload size limit

Author: hovnatan

docs/source/cli.rst

@@ -50,7 +50,8 @@ To upload images from folder to project use:
 If optional argument *recursive* is given then subfolders of :file:`<folder_path>` are also recursively
 scanned for available images.
 
-Optional argument *extensions* accepts comma separated list of image extensions to look for. If the argument is not given then value *jpg,png* is assumed.
+Optional argument *extensions* accepts comma separated list of image extensions
+to look for. If the argument is not given then value *jpg,png* is assumed.
 
 ----------
 
@@ -69,7 +70,7 @@ To upload videos from folder to project use:
                                [--end-time <float>]
 
 If optional argument *recursive* is given then subfolders of :file:`<folder_path>` are also recursively
-scanned for available images.
+scanned for available videos.
 
 Optional argument *extensions* accepts comma separated list of image extensions
 to look for. If the argument is not given then value *mp4,avi,mov,webm,flv,mpg,ogg* is assumed.

superannotate/__main__.py

@@ -94,20 +94,23 @@ def video_upload(args):
         '--target-fps',
         required=False,
         default=None,
+        type=float,
         help=
         'How many frames per second need to extract from the videos (approximate).  If not specified all frames will be uploaded'
     )
     parser.add_argument(
         '--start-time',
         required=False,
         default=0.0,
+        type=float,
         help=
         'Time (in seconds) from which to start extracting frames. Default is 0.0'
     )
     parser.add_argument(
         '--end-time',
         required=False,
         default=None,
+        type=float,
         help=
         'Time (in seconds) up to which to extract frames. If it is not specified, then up to end'
     )

superannotate/db/projects.py

@@ -36,8 +36,6 @@
 _api = API.get_instance()
 _NUM_THREADS = 10
 
-_RESIZE_CONFIG = {2: 4_000_000, 1: 100_000_000}  # 1: vector 2: pixel
-
 
 def create_project(project_name, project_description, project_type):
     """Create a new project in the team.
@@ -579,15 +577,6 @@ def get_image_array_to_upload(
     im_format = im.format
     im = im.convert("RGB")
     width, height = im.size
-    max_size = _RESIZE_CONFIG[project_type]
-    if (width * height) > max_size:
-        logger.warning("One of the images is being resized to smaller size.")
-        max_size_root = math.sqrt(max_size)
-        nwidth = math.floor(max_size_root * math.sqrt(width / height))
-        nheight = math.floor(max_size_root * math.sqrt(height / width))
-        im = im.resize((nwidth, nheight))
-        byte_io_orig = io.BytesIO()
-        im.save(byte_io_orig, im_format, subsampling=0, quality=100)
 
     if not image_quality_in_editor == 100 or im_format != "JPEG":
         byte_io_lores = io.BytesIO()
@@ -1637,10 +1626,11 @@ def _get_project_image_quality_in_editor(project, image_quality_in_editor):
         for setting in get_project_settings(project):
             if "attribute" in setting and setting["attribute"] == "ImageQuality":
                 return setting["value"]
+        return 60
     elif image_quality_in_editor == "compressed":
-        image_quality_in_editor = 60
+        return 60
     elif image_quality_in_editor == "original":
-        image_quality_in_editor = 100
+        return 100
     else:
         raise SABaseException(
             0,

superannotate/version.py

@@ -1 +1 @@
-__version__ = "2.2.4"
+__version__ = "2.2.5"

tests/sample_videos/Pexels Videos 1182652.mp4

@@ -0,0 +1,44 @@
+from pathlib import Path
+import filecmp
+import subprocess
+import time
+
+import superannotate as sa
+
+import pytest
+
+PROJECT_NAME1 = "test video upload1"
+PROJECT_NAME2 = "test video upload2"
+
+
+def test_image_quality_setting1(tmpdir):
+    tmpdir = Path(tmpdir)
+
+    projects = sa.search_projects(PROJECT_NAME1, return_metadata=True)
+    for project in projects:
+        sa.delete_project(project)
+
+    project = sa.create_project(PROJECT_NAME1, "test", "Vector")
+
+    sa.upload_videos_from_folder_to_project(
+        project, "./tests/sample_videos", target_fps=2
+    )
+
+    projects = sa.search_projects(PROJECT_NAME2, return_metadata=True)
+    for project in projects:
+        sa.delete_project(project)
+
+    project2 = sa.create_project(PROJECT_NAME2, "test", "Vector")
+
+    subprocess.run(
+        [
+            f"superannotate upload-videos --project '{PROJECT_NAME2}' --folder ./tests/sample_videos --target-fps 2"
+        ],
+        check=True,
+        shell=True
+    )
+    time.sleep(5)
+
+    assert len(sa.search_images(PROJECT_NAME1)) == len(
+        sa.search_images(PROJECT_NAME2)
+    )