optimize

Author: dshabin

superannotate/db/annotation_classes.py

@@ -330,8 +330,9 @@ def fill_class_and_attribute_names(annotations_json, annotation_classes_dict):
 def fill_class_and_attribute_ids(annotation_json, annotation_classes_dict):
     if "instances" not in annotation_json:
         return
+
     unknown_classes = {}
-    for ann in annotation_json["instances"]:
+    for ann in [i for i in annotation_json["instances"] if "className" in i]:
         if "className" not in ann:
             continue
         annotation_class_name = ann["className"]
@@ -342,8 +343,7 @@ def fill_class_and_attribute_ids(annotation_json, annotation_classes_dict):
                     'id': class_num,
                     'attribute_groups': {}
                 }
-    for k in unknown_classes:
-        annotation_classes_dict[k] = unknown_classes[k]
+    annotation_classes_dict = {**annotation_classes_dict, **unknown_classes}
 
     for ann in annotation_json["instances"]:
         if "className" not in ann:

tests/converter_test/test_conversion.py

@@ -105,7 +105,9 @@ def test_instance_segmentation_sa2coco_vector_empty_array(tmpdir):
     truth_path = input_dir / "truth.json"
     with open(truth_path, 'r') as f:
         truth = json.loads(f.read())
-    assert truth['annotations'][0]['bbox'] == data['annotations'][0]['bbox']
+    data['info']['date_created'] = 0
+    truth['info']['date_created'] = 0
+    assert truth == data
 
 
 def test_instance_segmentation_sa2coco_vector_empty_name(tmpdir):