Skip to content

Commit 74163a0

Browse files
committed
Fix ml model delete
1 parent 83ba485 commit 74163a0

File tree

3 files changed

+4
-3
lines changed

3 files changed

+4
-3
lines changed

src/superannotate/lib/app/interface/sdk_interface.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2682,7 +2682,6 @@ def delete_model(model):
26822682
logger.info("Failed to delete model, please try again")
26832683
else:
26842684
logger.info("Model successfully deleted")
2685-
raise AppException("Failed to delete model")
26862685
return model
26872686

26882687

src/superannotate/lib/core/usecases.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3538,7 +3538,8 @@ def __init__(self, model_id: int, models: BaseManageableRepository):
35383538
self._models = models
35393539

35403540
def execute(self):
3541-
self._models.delete(self._model_id)
3541+
self._response.data = self._models.delete(self._model_id)
3542+
return self._response
35423543

35433544

35443545
class StopModelTraining(BaseUseCase):

src/superannotate/lib/infrastructure/services.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -162,6 +162,7 @@ class SuperannotateBackendService(BaseBackendService):
162162
URL_GET_TEMPLATES = "templates"
163163
URL_PROJECT_WORKFLOW_ATTRIBUTE = "project/{}/workflow_attribute"
164164
URL_MODELS = "ml_models"
165+
URL_MODEL = "ml_model"
165166
URL_STOP_MODEL_TRAINING = "ml_model/{}/stopTrainingJob"
166167
URL_GET_MODEL_METRICS = "ml_models/{}/getCurrentMetrics"
167168
URL_BULK_GET_FOLDERS = "foldersByTeam"
@@ -888,7 +889,7 @@ def update_model(self, team_id: int, model_id: int, data: dict):
888889
return res.json()
889890

890891
def delete_model(self, team_id: int, model_id: int):
891-
delete_model_url = urljoin(self.api_url, f"{self.URL_MODELS}/{model_id}")
892+
delete_model_url = urljoin(self.api_url, f"{self.URL_MODEL}/{model_id}")
892893
res = self._request(delete_model_url, "delete", params={"team_id": team_id})
893894
return res.ok
894895

0 commit comments

Comments
 (0)