no more Skippable exceptions, deprecation messages and more

Author: VahagnTKA

src/superannotate/lib/app/interface/base_interface.py

@@ -46,9 +46,12 @@ def __init__(
                     f"CLI's superannotate init to generate default location config file."
                 )
             config_repo = ConfigRepository(config_path)
+            main_endpoint = config_repo.get_one("main_endpoint").value
+            if not main_endpoint:
+                main_endpoint = constants.BACKEND_URL
             token, host, ssl_verify = (
                 Controller.validate_token(config_repo.get_one("token").value),
-                config_repo.get_one("main_endpoint").value,
+                main_endpoint,
                 config_repo.get_one("ssl_verify").value,
             )
         self._host = host
@@ -57,19 +60,13 @@ def __init__(
         BaseInterfaceFacade.REGISTRY.append(self)
 
     @property
-    @abstractmethod
     def host(self):
-        raise NotImplementedError
+        return self._host
 
     @property
-    @abstractmethod
     def token(self):
-        raise NotImplementedError
+        return self._token
 
-    @property
-    @abstractmethod
-    def logger(self):
-        raise NotImplementedError
 
 
 class Tracker:

src/superannotate/lib/app/interface/sdk_interface.py

@@ -693,10 +693,9 @@ def assign_items(
 
         if not response.errors:
             logger.info(f"Assign items to user {user}")
-        elif response.status != "Skip":
+        else:
             raise AppException(response.errors)
 
-    @validate_arguments
     def unassign_items(
         self, project: Union[NotEmptyStr, dict], item_names: List[NotEmptyStr]
     ):
@@ -731,6 +730,14 @@ def assign_images(
         :param user: user email
         :type user: str
         """
+
+        warning_msg = (
+            "We're deprecating the assign_images function. Please use assign_items instead."
+             "Learn more. \n"
+             "https://superannotate.readthedocs.io/en/stable/superannotate.sdk.html#superannotate.assign_items"
+        )
+        logger.warning(warning_msg)
+        warnings.warn(warning_msg, DeprecationWarning)
         project_name, folder_name = extract_project_folder(project)
         project = self.controller.get_project_metadata(project_name).data
 
@@ -778,6 +785,14 @@ def unassign_images(
         :param image_names: list of images to unassign
         :type image_names: list of str
         """
+
+        warning_msg = (
+            "We're deprecating the unassign_images function. Please use unassign_items instead."
+             "Learn more. \n"
+             "https://superannotate.readthedocs.io/en/stable/superannotate.sdk.html#superannotate.unassign_items"
+        )
+        logger.warning(warning_msg)
+        warnings.warn(warning_msg, DeprecationWarning)
         project_name, folder_name = extract_project_folder(project)
 
         response = self.controller.un_assign_items(

src/superannotate/lib/core/exceptions.py

@@ -25,11 +25,6 @@ class AppValidationException(AppException):
     """
 
 
-class SkippableAppValidationException(AppValidationException):
-    """
-    App validation exception
-    """
-
 class ImageProcessingException(AppException):
     """
     App validation exception

src/superannotate/lib/core/reporter.py

@@ -45,8 +45,8 @@ def __exit__(self, type, value, traceback):
 
     def __del__(self):
         globs = globals()
-        if "SESSIONS" in globs and globs["SESSIONS"].get(self.pk):
-            del globs["SESSIONS"][self.pk]
+        # if "SESSIONS" in globs and globs.get("SESSIONS", {}).get(self.pk):
+        #     del globs["SESSIONS"][self.pk]
 
     @property
     def data(self):

src/superannotate/lib/core/usecases/base.py

@@ -4,7 +4,7 @@
 from typing import Iterable
 from typing import List
 
-from lib.core.exceptions import AppValidationException, SkippableAppValidationException
+from lib.core.exceptions import AppValidationException
 from lib.core.reporter import Reporter
 from lib.core.response import Response
 
@@ -24,9 +24,6 @@ def _validate(self):
                 if name.startswith("validate_"):
                     method = getattr(self, name)
                     method()
-            except SkippableAppValidationException as e:
-                self._response.errors = e
-                self._response.status = 'Skip'
             except AppValidationException as e:
                 self._response.errors = e
 

src/superannotate/lib/core/usecases/items.py

@@ -12,7 +12,7 @@
 from lib.core.entities import TmpImageEntity
 from lib.core.entities import VideoEntity
 from lib.core.exceptions import AppException
-from lib.core.exceptions import AppValidationException, SkippableAppValidationException
+from lib.core.exceptions import AppValidationException
 from lib.core.exceptions import BackendError
 from lib.core.reporter import Reporter
 from lib.core.repositories import BaseReadOnlyRepository
@@ -215,11 +215,7 @@ def validate_user(self, ):
             if c["user_id"] == self._user:
                 return True
 
-        logger.warning(
-            f"Skipping {self._user}. {self._user} is not a verified contributor for the {self._project.name}"
-        )
-
-        raise SkippableAppValidationException(f"{self._user} is not a verified contributor for the {self._project.name}")
+        raise AppValidationException(f"{self._user} is not a verified contributor for the {self._project.name}")
 
     def execute(self):
         if self.is_valid():
@@ -236,8 +232,6 @@ def execute(self):
                         f"Cant assign {', '.join(self._item_names[i: i + self.CHUNK_SIZE])}"
                     )
                     continue
-                else:
-                    self._response.status = 'Ok'
         return self._response