prepatch: Fixed code smells

Author: petruki

src/main/java/com/github/petruki/switcher/client/facade/ClientOfflineServiceFacade.java

@@ -267,6 +267,9 @@ private boolean processNumeric(final Strategy strategy, final Entry switcherInpu
 				final double numericSecondValue = NumberUtils.createNumber(strategy.getValues()[1]).doubleValue();
 				return numericInput >= numericFirstValue && numericFirstValue <= numericSecondValue;
 			}
+			break;
+		default:
+			throw new SwitcherInvalidOperationException(strategy.getOperation(), strategy.getStrategy());
 		}
 
 		throw new SwitcherInvalidOperationException(strategy.getOperation(), strategy.getStrategy());

src/test/java/com/github/petruki/switcher/client/SwitcherOfflineTest.java

@@ -672,6 +672,16 @@ public void offlineShouldReturnError_InvalidSnapshotOperationForNumeric() throws
 		switcher.isItOn();
 	}
 
+	@Test(expected = SwitcherInvalidOperationException.class)
+	public void offlineShouldReturnError_InvalidValuesForNumericValidation() throws Exception {
+		properties.put(SwitcherContextParam.SNAPSHOT_FILE, SNAPSHOTS_LOCAL + "/snapshot_fixture3.json");
+		SwitcherFactory.buildContext(properties, true);
+		
+		Switcher switcher = SwitcherFactory.getSwitcher("USECASE19");
+		switcher.prepareEntry(new Entry(Entry.NUMERIC, "1"));
+		switcher.isItOn();
+	}
+	
 	@Test(expected = SwitcherInvalidOperationException.class)
 	public void offlineShouldReturnError_InvalidSnapshotOperationForDate() throws Exception {
 		properties.put(SwitcherContextParam.SNAPSHOT_FILE, SNAPSHOTS_LOCAL + "/snapshot_fixture3.json");

src/test/resources/snapshot_fixture3.json

@@ -138,6 +138,22 @@
                                     ]
                                 }
                             ]
+                        },
+                        {
+                            "key": "USECASE19",
+                            "description": "It contains an invalid number of values for the given operation",
+                            "activated": true,
+                            "components": ["switcher-client"],
+                            "strategies": [
+                                {
+                                    "strategy": "NUMERIC_VALIDATION",
+                                    "activated": true,
+                                    "operation": "BETWEEN",
+                                    "values": [
+                                        "1"
+                                    ]
+                                }
+                            ]
                         }
                     ]
                 }