From 27c559f7a3993f1a95c6cd0df04af049b85e7ae5 Mon Sep 17 00:00:00 2001 From: DJ Majumdar Date: Thu, 7 May 2026 11:19:52 -0700 Subject: [PATCH] Add changeset for #626 dialog component types fix --- .changeset/proper-dialog-component-types.md | 14 ++++++++++++++ 1 file changed, 14 insertions(+) create mode 100644 .changeset/proper-dialog-component-types.md diff --git a/.changeset/proper-dialog-component-types.md b/.changeset/proper-dialog-component-types.md new file mode 100644 index 00000000..7d2acb89 --- /dev/null +++ b/.changeset/proper-dialog-component-types.md @@ -0,0 +1,14 @@ +--- +"@ladle/react": patch +--- + +fix: add proper types for dialog components + +Adds explicit prop types for `DialogOverlay` and `DialogContent` and removes +the `@ts-ignore` directives in the `Modal` component (the +[#626](https://github.com/tajo/ladle/pull/626) change). This unblocks +downstream consumers running stricter typecheckers — notably +[`@typescript/native-preview` (tsgo)](https://www.npmjs.com/package/@typescript/native-preview), +which surfaces the underlying `Property 'isOpen' does not exist on type +'IntrinsicAttributes & RefAttributes'` error from +`typings-for-build/app/src/ui.tsx` even with `skipLibCheck: true`.