Deactivate : should we delete the associate email?

[odelcroi]

matrix-authentication-service/crates/tasks/src/user.rs

Lines 114 to 120 in 67c974a

	// Delete all the email addresses for the user
	let n = repo
	.user_email()
	.remove_bulk(UserEmailFilter::new().for_user(&user))
	.await
	.map_err(JobError::retry)?;
	info!(affected = n, "Removed all email addresses for user");

Should we keep this behaviour?

It complicates the matching account logic because it is based on email.

Then matching existing accounts when deactivated fails, we should rely on username

[odelcroi]

@mcalinghee what you think?