Skip to content

incubation priority doesn't work, always incubates in order of decreasing distance #306

Description

@cantelope

Expected Behavior

With these settings:
"incubation_fill": true, "incubation_use_all": true, "incubation_priority": ["2km", "5km", "10km"], "incubation_restrict": { "2km": 901 },
I expect 2km eggs to be incubated first and on the unlimited incubater only.

Actual Behavior

10km and 5km eggs were incubated first. As a low level player, I only have the unlimited incubater.

Steps to Reproduce

Set incubation_priority as above.

Other Information

Eggs are always considered in decreasing distance:
eggs_by_distance = sorted(eggs, key=lambda x: x.total_distance, reverse=True)

It seems that the incubation priority is only referenced in:
for egg_distance in bot.config.incubation_priority:

And the egg_distance is only referenced in checking whether there is an egg restriction:
try: egg_restriction = int(bot.config.incubation_restrict[egg_distance])

There's no check whether the distance of the current egg being considered matches the egg_distance.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions