From d2c220adc6c79a8d945242894a549ace565b9bac Mon Sep 17 00:00:00 2001 From: the-Drunken-coder Date: Fri, 26 Jun 2026 19:29:59 -0400 Subject: [PATCH] test: reduce redundant SIDC coverage --- test/sidc-kit.test.mjs | 139 ----------------------------------------- 1 file changed, 139 deletions(-) diff --git a/test/sidc-kit.test.mjs b/test/sidc-kit.test.mjs index 1187353..94fad73 100644 --- a/test/sidc-kit.test.mjs +++ b/test/sidc-kit.test.mjs @@ -17,18 +17,10 @@ const infantryCompanySidc = "130310001512110000000000000000"; const armorPlatoonSidc = "130310001412050000000000000000"; const artilleryPlatoonSidc = "130310001413030000000000000000"; const reconnaissancePlatoonSidc = "130310001412130000000000000000"; -const friendlyAirFighterSidc = "130301000011010400000000000000"; -const friendlyAirRotaryWingSidc = "130301000011020000000000000000"; const hostileAirUavSidc = "130601000011030000000000000000"; const friendlySeaDestroyerSidc = "130330000012020300000000000000"; -const friendlySeaFrigateSidc = "130330000012020400000000000000"; const neutralMerchantShipSidc = "130430000014010000000000000000"; -const hostileSubmarineSidc = "130635000011010000000000000000"; -const friendlyUuvSidc = "130335000011040000000000000000"; -const friendlyTankSidc = "130315000012020000000000000000"; -const friendlyApcSidc = "130315000012010300000000000000"; const friendlyBaseSidc = "130320000012080200000000000000"; -const friendlyAirportSidc = "130320000012080300000000000000"; const friendlyCheckpointSidc = "130325000013030000000000000000"; const friendlyWaypointSidc = "130325000013180000000000000000"; const nonCuratedRenderableSidc = "130410001412110000000000000000"; @@ -55,23 +47,6 @@ function encodeBase64Utf8(value) { return btoa(binary); } -const expandedCatalogSidcs = [ - friendlyAirFighterSidc, - friendlyAirRotaryWingSidc, - hostileAirUavSidc, - friendlySeaDestroyerSidc, - friendlySeaFrigateSidc, - neutralMerchantShipSidc, - hostileSubmarineSidc, - friendlyUuvSidc, - friendlyTankSidc, - friendlyApcSidc, - friendlyBaseSidc, - friendlyAirportSidc, - friendlyCheckpointSidc, - friendlyWaypointSidc -]; - function buildInputFor(parts) { const input = { affiliation: parts.affiliation, @@ -117,16 +92,6 @@ test("renderSymbol returns SVG for a non-curated SIDC supported by milsymbol", ( assert.match(result.svg, /<\/svg>$/); }); -test("renderSymbol returns SVG for expanded curated SIDCs", () => { - for (const sidc of expandedCatalogSidcs) { - const result = renderSymbol(sidc, { size: 40 }); - - assert.equal(result.sidc, sidc); - assert.match(result.svg, /^$/); - } -}); - test("all curated catalog entries round-trip through public APIs", () => { for (const symbol of curatedSymbols) { const rendered = renderSymbol(symbol.sidc, { size: 32 }); @@ -497,110 +462,6 @@ test("buildSidc creates the expected known SIDC from structured parts", () => { ); }); -test("buildSidc creates expanded curated SIDCs from structured parts", () => { - assert.equal( - buildSidc({ - affiliation: "friend", - domain: "air", - entity: "aircraft", - entityType: "fighter" - }), - friendlyAirFighterSidc - ); - assert.equal( - buildSidc({ - affiliation: "hostile", - domain: "air", - entity: "aircraft", - entityType: "unmanned aerial vehicle" - }), - hostileAirUavSidc - ); - assert.equal( - buildSidc({ - affiliation: "friend", - domain: "sea surface", - entity: "surface combatant", - entityType: "frigate" - }), - friendlySeaFrigateSidc - ); - assert.equal( - buildSidc({ - affiliation: "hostile", - domain: "sea subsurface", - entity: "submarine" - }), - hostileSubmarineSidc - ); - assert.equal( - buildSidc({ - affiliation: "friend", - domain: "land equipment", - entity: "tank" - }), - friendlyTankSidc - ); - assert.equal( - buildSidc({ - affiliation: "friend", - domain: "land installation", - entity: "military infrastructure", - entityType: "airport" - }), - friendlyAirportSidc - ); - assert.equal( - buildSidc({ - affiliation: "friend", - domain: "control measure", - entity: "command and control point", - entityType: "checkpoint" - }), - friendlyCheckpointSidc - ); -}); - -test("buildSidc uses the correct field positions for land-unit fixtures", () => { - assert.equal( - buildSidc({ - affiliation: "friend", - domain: "land", - entity: "infantry", - echelon: "company" - }), - infantryCompanySidc - ); - assert.equal( - buildSidc({ - affiliation: "friend", - domain: "land", - entity: "armor", - entityType: "tank", - echelon: "platoon" - }), - armorPlatoonSidc - ); - assert.equal( - buildSidc({ - affiliation: "friend", - domain: "land", - entity: "artillery", - echelon: "platoon" - }), - artilleryPlatoonSidc - ); - assert.equal( - buildSidc({ - affiliation: "friend", - domain: "land", - entity: "reconnaissance", - echelon: "platoon" - }), - reconnaissancePlatoonSidc - ); -}); - test("invalid SIDCs produce a useful typed error", () => { assert.throws( () => explainSidc("not-a-sidc"),