Scope
The write/mutation pipeline — all files under nsc/cli/writes/.
Goal
Code review + simplify pass:
nsc/cli/writes/input.py (358 lines) — field collection and validationnsc/cli/writes/bulk.py (231 lines) — CSV/bulk write orchestrationnsc/cli/writes/preflight.py (182 lines) — pre-flight checks before writensc/cli/writes/apply.py (177 lines) — HTTP write dispatchnsc/cli/writes/confirmation.py (96 lines) — interactive confirmation prompt
Check for:
- Shared state threading through too many parameters (consider a context object)
- Validation logic that belongs in
model/ not cli/
- Duplicated error handling across the pipeline stages
- Clarity of the preflight → confirm → apply flow
Files
nsc/cli/writes/*.py- Related tests:
tests/cli/writes/
Scope
The write/mutation pipeline — all files under
nsc/cli/writes/.Goal
Code review + simplify pass:
nsc/cli/writes/input.py(358 lines) — field collection and validationnsc/cli/writes/bulk.py(231 lines) — CSV/bulk write orchestrationnsc/cli/writes/preflight.py(182 lines) — pre-flight checks before writensc/cli/writes/apply.py(177 lines) — HTTP write dispatchnsc/cli/writes/confirmation.py(96 lines) — interactive confirmation promptCheck for:
model/notcli/Files
nsc/cli/writes/*.pytests/cli/writes/