Fix guide folder casing for camera and graphics#758
Conversation
❌ Deploy Preview for splashkit failed.
|
|
Nice small and focused fix overall. The changes clearly address the guide folder casing issue, and lowercasing plus sorting the directory names should help keep the generated output more consistent across different platforms. I also like that the PR stays limited to only the relevant files without including unrelated generated changes. The comments added in the script are clear and make the logic easier to follow as well. Looks good to me. |
jankiluitel
left a comment
There was a problem hiding this comment.
Renaming the guide folders to lowercase enhances uniformity and prevents any case-sensitivity problems across contexts, plus it looks good.
For consistent and reliable output, the JSON generating script update is also a good enhancement.
This shouldn't introduce any broken links because I have verified that there are no references to the previous Camera or Graphics routes.
Accepted
222448082Ashen
left a comment
There was a problem hiding this comment.
Description
This PR introduces stability to the JSON generation process and significantly expands the documentation for "Dynamic Camera Control" and "Shape Modelling" by adding comprehensive code examples in C++ (Top-level and OOP), C#, and Python.
Type of change
- Documentation (update or new)
- Scripting/Infrastructure improvement
How Has This Been Tested?
- Verified script logic in
scripts/json-files-script.cjs(stable sorting and casing). - Manually reviewed code blocks in
.mdxfiles for syntax and consistency. - npm run build (Blocked by local environment module issues, but script logic was verified).
Checklist
If involving code
- My code follows the style guidelines of this project
- I have performed a self-review of my own code
- I have commented my code in hard-to-understand areas
- I have made corresponding changes to the documentation
- My changes generate no new warnings (One minor syntax error found)
If modified config files
- Checked
scripts/json-files-script.cjs
Folders and Files Added/Modified
- Modified:
-
scripts/json-files-script.cjs -
src/content/docs/guides/camera/1-dynamic-camera-control.mdx -
src/content/docs/guides/graphics/2-shape-modelling.mdx
-
|
@222448082Ashen Could you please approve this PR ? |
ZGT23
left a comment
There was a problem hiding this comment.
Looks good to me.
This PR is small, focused, and clearly addresses the guide folder casing issue for the camera and graphics guide paths. Updating scripts/json-files-script.cjs to convert directory names to lowercase and sort them should make the generated guide groups more consistent across different operating systems.
I also like that the PR keeps the scope limited and does not include unrelated generated file changes. The logic is simple, readable, and should help prevent future casing-related path issues.
Approved.
Description
Fixed duplicate guide folder casing issues for
cameraandgraphics.This PR moves the uppercase tracked guide files into the lowercase guide folders and updates the guide directory generation logic so folder names are lowercased and sorted consistently. This helps avoid cross-platform Git/path issues.
Type of change
How Has This Been Tested?
Tested locally by checking the staged guide path changes and updating the guide directory generation logic.
I checked that:
Testing Checklist
Checklist
If involving code
If modified config files
Folders and Files Added/Modified
Additional Notes
This PR is intentionally kept small and focused on the guide folder casing issue only.