refactor: minor cleanup

Author: pipech

raven/omni_channel_chat/api/webhooks.py

@@ -33,6 +33,6 @@ def handle() -> Response:
 	"""
 	slug = extract_provider_slug()
 	provider = get_omni_channel_chat_provider(slug=slug)
-	return provider.handle_frappe_api(
-		callback=OmniChannelRavenConnector(provider=provider).receive_from_provider
-	)
+	connector = OmniChannelRavenConnector(provider=provider)
+
+	return provider.handle_frappe_api(callback=connector.receive_from_provider)

raven/omni_channel_chat/omni_channel_raven_connector.py

@@ -5,9 +5,9 @@
 
 from raven.omni_channel_chat.models.message import (
 	BaseMessage,
+	FileContent,
 	FileMessage,
 	FileUrl,
-	FileContent,
 	ImageMessage,
 	SenderInfo,
 	TextMessage,
@@ -47,7 +47,9 @@ def _build_outbound_message(
 ) -> BaseMessage:
 	msg_type = raven_message.message_type
 	if msg_type == "Text":
-		return TextMessage(provider=provider_name, user_id="", text=raven_message.content or "", sender=sender)
+		return TextMessage(
+			provider=provider_name, user_id="", text=raven_message.content or "", sender=sender
+		)
 	file_url = raven_message.file
 	if file_url and file_url.startswith("/"):
 		file_url = get_url(file_url)
@@ -62,7 +64,6 @@ def _build_outbound_message(
 	raise ValueError(f"Unsupported outbound message type: {msg_type}")
 
 
-
 class OmniChannelRavenConnector:
 	"""Bridges Raven and an external omni-channel provider.
 
@@ -195,7 +196,7 @@ def handle_webhook(self, body: bytes, headers: dict) -> None:
 		for message in messages:
 			self.receive_from_provider(message)
 
-	def receive_from_provider(self, message: BaseMessage) -> "RavenChannel":
+	def receive_from_provider(self, message: BaseMessage) -> None:
 		"""Inbound: turn a provider webhook payload into a Raven message.
 
 		Creates the Frappe user, Raven user, and channel on first contact,
@@ -210,9 +211,9 @@ def receive_from_provider(self, message: BaseMessage) -> "RavenChannel":
 		raven_channel = self._get_or_create_channel(raven_user=raven_user)
 		self._save_inbound_message(raven_channel=raven_channel, message=message)
 
-		return raven_channel
-
-	def _save_inbound_message(self, *, raven_channel: "RavenChannel", message: BaseMessage) -> None:
+	def _save_inbound_message(
+		self, *, raven_channel: "RavenChannel", message: BaseMessage
+	) -> None:
 		doc = frappe.new_doc(doctype="Raven Message")
 		doc.update(
 			{
@@ -225,7 +226,9 @@ def _save_inbound_message(self, *, raven_channel: "RavenChannel", message: BaseM
 		)
 		if isinstance(message, TextMessage):
 			doc.text = message.text
-		elif isinstance(message, (ImageMessage, FileMessage)) and isinstance(message.file, FileContent):
+		elif isinstance(message, (ImageMessage, FileMessage)) and isinstance(
+			message.file, FileContent
+		):
 			file_doc = frappe.get_doc(
 				{
 					"doctype": "File",