From 12b06512b16ff0cd515b183907e046ed35be83f5 Mon Sep 17 00:00:00 2001 From: BrentWHR Date: Thu, 18 Dec 2025 12:27:31 +0100 Subject: [PATCH 1/4] fix example of showing quantiles in geom_violin --- R/geom-violin.R | 2 +- man/geom_violin.Rd | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/R/geom-violin.R b/R/geom-violin.R index 576fb98fb7..4ae312c576 100644 --- a/R/geom-violin.R +++ b/R/geom-violin.R @@ -65,7 +65,7 @@ #' p + geom_violin(fill = "grey80", colour = "#3366FF") #' #' # Show quartiles -#' p + geom_violin(draw_quantiles = c(0.25, 0.5, 0.75)) +#' p + geom_violin(quantile.linetype = 'solid') #' #' # Scales vs. coordinate transforms ------- #' if (require("ggplot2movies")) { diff --git a/man/geom_violin.Rd b/man/geom_violin.Rd index 9c1c1a23b9..4a9389f5c4 100644 --- a/man/geom_violin.Rd +++ b/man/geom_violin.Rd @@ -238,7 +238,7 @@ p + geom_violin(aes(fill = factor(am))) p + geom_violin(fill = "grey80", colour = "#3366FF") # Show quartiles -p + geom_violin(draw_quantiles = c(0.25, 0.5, 0.75)) +p + geom_violin(quantile.linetype = 'solid') # Scales vs. coordinate transforms ------- if (require("ggplot2movies")) { From 95346050495f319a4fe99b613e433aa62b92b7cf Mon Sep 17 00:00:00 2001 From: BrentWHR Date: Thu, 18 Dec 2025 12:28:30 +0100 Subject: [PATCH 2/4] add additional violin quantile example --- R/geom-violin.R | 3 +++ man/geom_violin.Rd | 3 +++ 2 files changed, 6 insertions(+) diff --git a/R/geom-violin.R b/R/geom-violin.R index 4ae312c576..4b6d2bc113 100644 --- a/R/geom-violin.R +++ b/R/geom-violin.R @@ -67,6 +67,9 @@ #' # Show quartiles #' p + geom_violin(quantile.linetype = 'solid') #' +#' # Show different quantiles +#' p + geom_violin(quantiles = c(0.2, 0.4, 0.6, 0.8), quantile.linetype = 'solid') +#' #' # Scales vs. coordinate transforms ------- #' if (require("ggplot2movies")) { #' # Scale transformations occur before the density statistics are computed. diff --git a/man/geom_violin.Rd b/man/geom_violin.Rd index 4a9389f5c4..07524bddd3 100644 --- a/man/geom_violin.Rd +++ b/man/geom_violin.Rd @@ -240,6 +240,9 @@ p + geom_violin(fill = "grey80", colour = "#3366FF") # Show quartiles p + geom_violin(quantile.linetype = 'solid') +# Show different quantiles +p + geom_violin(quantiles = c(0.2, 0.4, 0.6, 0.8), quantile.linetype = 'solid') + # Scales vs. coordinate transforms ------- if (require("ggplot2movies")) { # Scale transformations occur before the density statistics are computed. From 339470b572281f48f42319aa94fae18ceeefc8c1 Mon Sep 17 00:00:00 2001 From: BrentWHR Date: Thu, 18 Dec 2025 12:28:47 +0100 Subject: [PATCH 3/4] clarify how quantiles can be changed in deprecation message --- R/geom-violin.R | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/R/geom-violin.R b/R/geom-violin.R index 4b6d2bc113..a345c663ce 100644 --- a/R/geom-violin.R +++ b/R/geom-violin.R @@ -116,7 +116,8 @@ geom_violin <- function(mapping = NULL, data = NULL, deprecate( "4.0.0", what = "geom_violin(draw_quantiles)", - with = "geom_violin(quantiles.linetype)" + with = "geom_violin(quantiles.linetype)", + details = "Quantile distribution can be changed with geom_violin(quantiles)" ) check_numeric(draw_quantiles) From 3fe68a217f9abd58288d314d26fa9f55d03ba12d Mon Sep 17 00:00:00 2001 From: Teun van den Brand Date: Thu, 18 Dec 2025 13:41:06 +0100 Subject: [PATCH 4/4] polish deprecation message --- R/geom-violin.R | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/R/geom-violin.R b/R/geom-violin.R index a345c663ce..13af20a195 100644 --- a/R/geom-violin.R +++ b/R/geom-violin.R @@ -116,8 +116,8 @@ geom_violin <- function(mapping = NULL, data = NULL, deprecate( "4.0.0", what = "geom_violin(draw_quantiles)", - with = "geom_violin(quantiles.linetype)", - details = "Quantile distribution can be changed with geom_violin(quantiles)" + with = "geom_violin(quantile.linetype)", + details = "Quantiles can be changed with `geom_violin(quantiles)`" ) check_numeric(draw_quantiles)