Skip to content

Decide on consistent units and arg names #2

@timcdlucas

Description

@timcdlucas

I think I agreed to switch to match yours.

tm, v

I think "radial distance to the detected animal" and "a priori maximum radial distance" should be given different but related names.
Same goes for angle of detection.

I'll make a more thorough glossary in this thread at some point.

2f74527
Changes rem (from remBoot).

Still accepts the same units (r in meters, v in km per day and tm in hours
Convert to r in km, tm in days (v remains in km per day) for actual calculation.
28396fd
Changes gREM.

Now only accepts units to match rem (r in meters, v in km per day and tm in hours
Convert to r in km, tm in days (v remains in km per day) for actual calculation.
b63df6a
Tests and confirms that rem and gREM give the same results. Though I note that in my emails I forgot that you cannot just put theta = 2*pi into the REM model.

d2b3e31
My changes to rem have broken your regression test. But this has also made me think that the data in hDat is in kilometers for r, not meters as requested in the docs. So I just want to check whether you prefer meters or kilometers for r. But that can be discussed in the "what units should we use" wiki.

So let me know what you think. I haven't carefully checked through other functions to see if anything else needs changing.

Not sure where to keep discussions. Maybe here is best.

The wiki is now up to date.
https://github.com/timcdlucas/RandEM/wiki/Glossary

However, I am wondering whether we should use different names for 1) a known or estimated value, typically a property of the sensor (e.g. the detection distance of a sensor) vs 2) a realisation of a related property such as the distance between a specific animal and the sensor.

Actually the only place I can see the latter is in hDat and it's called dist there. However, in hDat, the observed angle of animals is called theta while in gREM the known detection angle of the sensor is called theta. As usual I'm perfectly happy to change gREM arg names.

I think it would make sense to have different names for each value. Perhaps the value in hDat (and, hence, distance-to-target) should be changed to d. One of the theta arguments could be changed to phi. Like theta, phi is often associated with plane angles in mathematics.

Yup those both sound like good plans to me.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions