Unrealized vs realized currency exchange variations

[pakricard]

Currently, in Currencies.php, when a currency rate is updated, we adjust the value of all foreign-currency bank accounts with the new exchange rate, so the balance sheet shows the most updated value.

It is an "unrealized gain" as the next update of currency rate will trigger another update, and effectively, we have not "sold" or "bought" any foreign currency.

But, we are using the GL account "Sales Exchange Variances GL Account:" from CompanyPreferences.php, $_SESSION['CompanyRecord']['exchangediffact'], which, by its definition is a realized P/L, as it is the realized P/L due to sales in foreign currency.

So, to my understanding, we are mixing unrealized with realized P/L.

Should we add a parameter in CompanyPreferences.php similar to"Sales Exchange Variances GL Account:" to manage these unrealized P/L "Currency exchange unrealized P/L" and use this GL account in the calculations in Currencies.php lines 151-229?

R