[Bug report] Since yesterday, the profile_helper.sh script is broken

[jgb]

Describe the bug

Since the commit of yesterday, tinted-shell is broken for me. I get these errors when I open my shell, and the colors are messed up:

mkdir: cannot create directory ‘’: No such file or directory
bash: /theme_name: Permission denied
bash: /theme_name: No such file or directory
mkdir: cannot create directory ‘’: No such file or directory
bash: /theme_name: Permission denied
bash: [: base16-unikitty-dark: integer expected
ln: failed to create symbolic link '/base16_shell_theme': Permission denied
Attempted symbolic link failed. Ensure $BASE16_SHELL_PATH       and $BASE16_SHELL_COLORSCHEME_PATH are valid paths.

Expected behavior

The day before, everything worked fine.

System

Debian testing/sid

rxvt-unicode and xterm, with bash, same problem.

Minimal configuration file

I use the snippet from the USAGE.md to run profile_helper.sh

[jgb]

As I mentioned in one of the commits, it's the removal of $ for some variables that is the culprit. Putting back the $ on line 9 of profile_helper.sh fixes the problem (most of it, at least).
After doing that on line 9 I still get this error, but at least my colors seem ok:

bash: [: unikitty-dark: integer expected

[JamyGolden]

Thanks for the bug report. I’ll push a fix in the next hour or two

[JamyGolden]

Just merged, let me know if you have any other issues

[jgb]

thanks @JamyGolden that fixes most of it!
I'm still seeing this however, which is also new since the commit of yesterday:

bash: [: unikitty-dark: integer expected

It's less clear to me where that is coming from

[jgb]

@JamyGolden actually I found the second bug, it's in line 87 of profile helper:

if [ "$theme_name" -eq "$current_theme_name" ] && [ -z "$force_load" ]; then

the commit replaced == with -eq, but -eq is a numerical comparison.
We're comparing strings here, not numbers.
I would propose to put back the ==, tested it locally and that solves the second error I'm seeing.

[JamyGolden]

I needed to do a rebase to fix the previous commit, can you do a git checkout main && git fetch && git reset --hard origin/main instead of a git pull?