Appears not to support streaming

[aantron]

e.g.:

dream-encoding/lib/dream_encoding.ml

Lines 194 to 195 in dde4204

	let%lwt body = Dream.body response in
	Lwt.return @@ with_encoded_body ~algorithm body response

This appears to read the entire body into memory, and then compress it. I assume (perhaps wrongly) that the underlying compression algorithms support streaming, and it seems like streaming would be more beneficial for precisely the kind of responses that you wouldn't want to load into memory an extra time (large ones).

[tmattio]

assume (perhaps wrongly) that the underlying compression algorithms support streaming

It does! In fact, the compression function (which is almost identical to decompress's documentation example) creates a stream from the given string, so refactoring this to work on stream responses should be trivial 🤞

I'll get to it as soon as I have some spare time

[aantron]

I'll get to it as soon as I have some spare time

No rush! And I think you will likely need some improvements in Dream's streaming APIs to get it done, so do bug me :)