Skip to content

Dream error_handler footgun #6

@reynir

Description

@reynir

Hi! Thanks for this project. I discovered a footgun which is possibly more to blame dream than dream-encoding.

The case is when you use an error handler the suggested response will have gone through dream-encoding and be compressed. Then, an error handler may alter the response to have some nicer looking html. The problem is this will not go through Dream_encoding.compress again so the body will be uncompressed, but keep the Transfer-encoding header added by dream-encoding.

The example snippet in the documentation for Dream.error_template is subject to this: https://aantron.github.io/dream/#val-error_template

I think it would be worth mentioning this somewhere. Perhaps both in the README and in the .mli. (I apologize if I missed this being mentioned somewhere)

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions