Skip to content
This repository was archived by the owner on Jan 26, 2023. It is now read-only.
This repository was archived by the owner on Jan 26, 2023. It is now read-only.

axios adapter configuration #33

@noctifer20

Description

@noctifer20

Hey guys!
Thank you for your great work!

Here I see that axios adapter can be passed from the client configuration, but it doesn't seem to be used anywhere in HttpApi.

This creates a problem, when in project you have multiple axios versions, and it's impossible to configure axios instance which is being used in the client.
Like in this example:

import axios from 'axios';
import axiosThrottle from 'axios-request-throttle';
axiosThrottle.use(axios, { requestsPerSecond: 0.5 });

axios used in axiosThrottle configuration is not the same as the one used by HttpApi, hence throttling is not applying.

I'd recommend to either actually use the adapter or move axios from here to peerDependencies

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions