Email as SID

[rogeriolino]

When I do login generate in session table a new record with SID as my fullname.

Can I change it to save my email (for compatibility with my old tickets)?

[dairiki]

There is no official way to do that right now.

Currently, the code for determining the SID is bit of a mess. I hesitate to add an official option (for setting SID from email) without first cleaning that up. I'll see if I can put some work into that in the next few weeks.

That said, it would not be hard to achieve what you want by editing authopenid.py around line 603 to set authname = email. (Probably, also, it would be good to add a test to ensure that the provider supplied an email address before allowing the authentication.) Here is a totally untested patch:

--- a/authopenid/authopenid.py
+++ b/authopenid/authopenid.py
@@ -583,7 +583,7 @@ class AuthOpenIdPlugin(Component):
                     if new_user:
                         remote_user = new_user

-            if allowed:
+            if allowed and email:
                 cookie = hex_entropy()
                 cookie_lifetime = self.trac_auth_cookie_lifetime

@@ -600,10 +600,7 @@ class AuthOpenIdPlugin(Component):

                 self._commit_session(session, req)

-                if req.session.get('name'):
-                    authname = req.session['name']
-                    if self.combined_username:
-                        authname = '%s <%s>' % (authname, remote_user)
+                authname = email

                 # Possibly lower-case the authname.
                 if self.lowercase_authname:

[rogeriolino]

I had placed a workaround: "authname = email" after if statement, like your patch. And is working fine. So I have not applied your code.

But it would be better if you could configure in the trac.ini. Like:

authname = name | email

However, this is a great plugin!

Regards

[shimizukawa]

+1