feat(executor): centralize log-watching and merge odoo logs#35
Open
hailangvn wants to merge 4 commits into
Open
feat(executor): centralize log-watching and merge odoo logs#35hailangvn wants to merge 4 commits into
hailangvn wants to merge 4 commits into
Conversation
hailangvn
force-pushed
the
feat/watch-odoo-log
branch
from
f76cbdb to
50889e6
Compare
Moves the repeated journalctl-streaming block from configure, restart, status, and update commands into a single Executor.watch_logs() method that also merges the Odoo logfile (read from config/odoo.conf) when one is configured. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Forge ID: F#T67863
hailangvn
force-pushed
the
feat/watch-odoo-log
branch
from
50889e6 to
6922def
Compare
Contributor
|
one more thing needed:
|
Contributor
|
I'm not sure if you're familiar with |
Comment on lines
+120
to
+128
| try: | ||
| home_dir = self.capture("echo $HOME") | ||
| conf = f"{home_dir}/{instance_name}/config/odoo.conf" | ||
| raw = self.capture(f"grep -E '^logfile' {conf} | cut -d= -f2 | tr -d ' ' || true") | ||
| candidate = (raw or "").strip() | ||
| if candidate and candidate.lower() not in ("false", "none"): | ||
| log_file = candidate | ||
| except ExecutorError: | ||
| pass |
Contributor
There was a problem hiding this comment.
only if instance of type odoo
…atch upgrade log Move DeployType enum from individual command modules into config.py, add --type option to restart/status commands, and update watch_logs to only merge Odoo log files when the deploy type is "odoo". Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
hailangvn
force-pushed
the
feat/watch-odoo-log
branch
from
99954e6 to
e1284c8
Compare
Collaborator
Author
|
Thanks for your comments. The PR has been updated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves the repeated journalctl-streaming block from configure, restart, status, and update commands into a single Executor.watch_logs() method that also merges the Odoo logfile (read from config/odoo.conf) when one is configured.
Co-Authored-By: Claude Sonnet 4.6 noreply@anthropic.com