fix(settings): make agent model selectors editable and persistent (#431)#474
Open
trsdn wants to merge 2 commits into
Open
fix(settings): make agent model selectors editable and persistent (#431)#474trsdn wants to merge 2 commits into
trsdn wants to merge 2 commits into
Conversation
- Fix stale closure bug in saveRole callback by adding 'roles' to deps array - Add enhanced toast notification showing old→new model on change - Add cursor:pointer CSS to make select dropdowns visually interactive - Add server logging when model is updated via PUT /api/roles - Add debug logging in ceremony execution to track model application - Add comprehensive integration tests for model persistence flow - Document model selection in Dashboard Settings section Closes #431 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
- Verify model dropdown is enabled (not disabled) - Test changing model value triggers dirty state - Verify Save button becomes enabled - Confirm toast shows 'model:' change notification - Restore original value after test Provides evidence that acceptance criteria are met: ✅ Model selectors ARE editable ✅ Changes persist (Save button works) ✅ UI confirmation shown (toast with 'model:') Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #431 — Settings model selectors are now fully editable with proper persistence to .aiscrum/config.yaml and visual confirmation.
Changes
saveRolecallback by addingrolesto dependency arraycursor: pointerCSS to select dropdowns for better UXTest Coverage
tests/dashboard/settings-model-update.test.ts:Verification
✅ Lint clean: 0 errors (34 pre-existing warnings)
✅ Type clean: tsc --noEmit passed
✅ Tests pass: 823 tests passed (7 new tests added)
✅ Diff size: 270 lines (54 production + 216 test) — within 300 line limit
Definition of Done
Closes #431