From 7ee5a38f032deacba713f6b2958f67c0f0fbdab2 Mon Sep 17 00:00:00 2001 From: bradAGI <46579244+bradAGI@users.noreply.github.com> Date: Mon, 24 Aug 2026 15:15:08 -0400 Subject: [PATCH] feat(autogen): add AG2-019, ambiguous tool name Ports the ambiguous-name check to autogen. Claude SDK (CSDK-007), OpenAI (OAI-007), ADK (ADK-007), and MCP (MCP-003) all ship it; the five newer packs had none. The tool name sits directly beside the description in what the model sees, so it is half the selection signal, and a generic verb like process or handle spends that half on nothing. --- autogen/tool_definition.yaml | 31 +++++++++++++++++++++++++++++++ 1 file changed, 31 insertions(+) diff --git a/autogen/tool_definition.yaml b/autogen/tool_definition.yaml index 7c64aca..36289ea 100644 --- a/autogen/tool_definition.yaml +++ b/autogen/tool_definition.yaml @@ -54,3 +54,34 @@ rules: Annotate every parameter with a concrete type (str, int, list[str], a typing.Annotated description, etc.). AutoGen propagates these annotations into the schema the model sees, so the model emits correctly-shaped arguments. + + - id: AG2-019 + title: Ambiguous AutoGen tool name + severity: low + confidence: 0.9 + language: python + applies_to: + - autogen_tool + scope: tool + match: + name_in: + - process + - handle + - run + - do + - execute + - perform + - work + - go + - thing + - stuff + explanation: > + The tool name is a generic verb that says nothing about what the tool + acts on. The name sits directly beside the description in what the model + sees, so it is half the selection signal, and a name like process or + handle spends that half on nothing — the model either calls the tool for + the wrong job or passes over it entirely. Each wrong pick costs a full round of the conversation — propose, execute, reply — so an ambiguous name spends the AG2-004 max_round budget rather than the chat reaching an answer. + fix: > + Rename to a verb-object form that names the thing acted on: + summarize_invoice, refund_charge, fetch_order_status. Keep the + description for the detail and let the name carry the subject.