EscrowService generates IDs from Date.now() with no collision protection

[meshackyaro]

Description

EscrowService.create() (src/escrow/escrow.service.ts) generates escrow IDs as `esc-${Date.now()}` — a millisecond timestamp with no random component. Two escrows created within the same millisecond (entirely possible under concurrent requests, which Node.js's single-threaded event loop can still interleave between the Date.now() call and the Map.set()) get the exact same ID, and the second create() call silently overwrites the first escrow record in the in-memory Map. Compare this to GigService.create() (src/gig/gig.service.ts), which already appends a random suffix (`gig-${Date.now()}-${Math.random().toString(36).slice(2, 8)}`), and DisputeSagaService.escalate() (src/dispute/dispute-saga.service.ts), which does the same for saga IDs — EscrowService is the one core identifier generator that doesn't follow this pattern.

Component

Backend

Difficulty

🟢 Easy

Tasks

• Change EscrowService.create()'s ID generation to include a random/UUID component, consistent with GigService/DisputeSagaService's pattern (or adopt randomUUID() as used in UserProfileService/MigrationRunnerService)
• Add a regression test that creates many escrows in a tight loop and asserts all IDs are unique

Acceptance Criteria

• Escrow IDs are collision-resistant under concurrent creation
• A test proves no duplicate IDs occur across a burst of rapid create() calls

Estimated Time

1-2 hours

[TheShnider]

@TheShnider has applied to work on this issue as part of the Stellar Wave Program's 8th wave.

Hi. I have reviewed this issue and would like to work on it.

ℹ️ Repo Maintainers: To accept this application, review their application or assign @TheShnider to this issue.

[nursetechie]

@nursetechie has applied to work on this issue as part of the Stellar Wave Program's 8th wave.

Interested in contributing to this issue, please assign

ℹ️ Repo Maintainers: To accept this application, review their application or assign @nursetechie to this issue.

[Adeyinka0123]

@Adeyinka0123 has applied to work on this issue as part of the Stellar Wave Program's 8th wave.

Hello Maintainer, I’d be happy to take ownership of this issue and deliver a quality pull request once completed.

ℹ️ Repo Maintainers: To accept this application, review their application or assign @Adeyinka0123 to this issue.

[drips-wave]

Congratulations, @nursetechie! 🎉 Your application was accepted by the repo's maintainers, and the issue is due on August 31, 2026.

🧑‍💻 @nursetechie: Please resolve the issue such that the repo's maintainers have enough time to review your contribution before the due date. You'll earn Points for completing the issue on-time, which will make you eligible for a share of the Stellar Wave Program's reward pool.

Warning

When opening a PR, please link it to this issue to ensure it gets tracked accurately. Points are awarded when this issue is marked as completed by the maintainer.

🤠 Repo maintainers: Please keep an eye on the contributor's progress and review their work before the due date. You can manage this issue, including adjusting its complexity and points, here.

🌊 Happy Wave 🌊

[grantfox-oss]

🎉 This issue has been marked as completed on GrantFox!

@nursetechie's PR #256 was approved and merged by @meshackyaro.

🏆 @nursetechie: You earned 35 FoxPoints for this contribution! Your current tier: Explorer (516 total points). Track your full progress on GrantFox.

👏 Great work, @nursetechie! Keep contributing to trustflow-protocol.