Add "DOM" to tsconfig.json's lib array for browser-facing wallet/signing modules

[meshackyaro]

Description

tsconfig.json's compilerOptions.lib is ["ES2022"] only — no "DOM". Yet src/stellar/signing.ts (if (typeof window === 'undefined' || !(window as any).freighter)), src/wallet/albedo.ts (if (typeof window === 'undefined') { return null; } return (window as any).albedo), and src/wallet/freighter.ts (three separate window references) all reference the global window identifier directly. Without the DOM lib, TypeScript has no declaration for window at all, so tsc --noEmit fails with TS2304: Cannot find name 'window' at every one of these call sites — even though the code is deliberately written to be safe in a non-browser environment via the typeof guard, the guard itself doesn't compile.

Component

SDK

Difficulty

🔴 Hard

Tasks

• Decide the isomorphic-build strategy: add "DOM" to the shared tsconfig.json's lib (simplest, but makes all of src/ see DOM globals even where inappropriate), or isolate browser-only files (signing.ts, wallet/*.ts) under a separate tsconfig with its own lib array
• Apply the chosen fix
• Re-run tsc --noEmit to confirm the window-related errors are gone
• Confirm tsup.config.ts's platform: 'neutral' build still produces correct output for both Node and browser consumers after the change

Acceptance Criteria

• tsc --noEmit reports no undeclared-window errors
• The Node-only build path is unaffected by newly-visible DOM globals (no accidental use of browser-only APIs outside the wallet/signing modules)

Estimated Time

2-3 days

[muokwejosh-cloud]

@muokwejosh-cloud has applied to work on this issue as part of the Stellar Wave Program's 8th wave.

I’ve reviewed the issue details and documentation, and I understand the problem statement and expected outcome. Please assign this task to me — I’m ready to start working on it.

ℹ️ Repo Maintainers: To accept this application, review their application or assign @muokwejosh-cloud to this issue.

[Queenode]

@Queenode has applied to work on this issue as part of the Stellar Wave Program's 8th wave.

Hi maintainer, I would like to work on this issue.
Kindly assign

ℹ️ Repo Maintainers: To accept this application, review their application or assign @Queenode to this issue.

[drips-wave]

Congratulations, @Queenode! 🎉 Your application was accepted by the repo's maintainers, and the issue is due on August 31, 2026.

🧑‍💻 @Queenode: Please resolve the issue such that the repo's maintainers have enough time to review your contribution before the due date. You'll earn Points for completing the issue on-time, which will make you eligible for a share of the Stellar Wave Program's reward pool.

Warning

When opening a PR, please link it to this issue to ensure it gets tracked accurately. Points are awarded when this issue is marked as completed by the maintainer.

🤠 Repo maintainers: Please keep an eye on the contributor's progress and review their work before the due date. You can manage this issue, including adjusting its complexity and points, here.

🌊 Happy Wave 🌊

[grantfox-oss]

🎉 This issue has been marked as completed on GrantFox!

@Queenode's PR #253 was approved and merged by @meshackyaro.

🏆 @Queenode: You earned 35 FoxPoints for this contribution! Your current tier: Explorer (853 total points). Track your full progress on GrantFox.

👏 Great work, @Queenode! Keep contributing to trustflow-protocol.

[drips-wave]

This issue has been completed by @Queenode as part of the Stellar Wave Program's 8th Wave 🥳

😎 @Queenode: You earned 200 Points for completing this issue! After the current Wave ends, you'll be eligible for a percentage of the Wave's reward pool based on the percentage of total points you've earned. Learn more here. You can also Leave a review to share your experience working on this issue.

🧑‍💻 Repo maintainers: How'd the contributor do? Leave a review to share your experience working with them.