From 16d126d791768865a629c77002ab18e9f1889794 Mon Sep 17 00:00:00 2001 From: airy Date: Fri, 21 Jun 2013 14:38:01 +0800 Subject: [PATCH 1/2] 1. Automatically add DIRECTORY_SEPARATOR for log path; 2.Add caller __FILE__ and __LINE__ in log message --- Helper/Logger.php | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/Helper/Logger.php b/Helper/Logger.php index 75263c2..7e7d366 100644 --- a/Helper/Logger.php +++ b/Helper/Logger.php @@ -26,6 +26,9 @@ class Logger */ public function __construct($dir) { + if (!in_array(substr($dir, -1) array("/", "\\"))) { + $dir .= DIRECTORY_SEPARATOR; + } $this->_dir = $dir; } @@ -39,8 +42,10 @@ public function __construct($dir) */ public function __call($name, array $args) { + $stack = debug_backtrace(DEBUG_BACKTRACE_PROVIDE_OBJECT, 1); + $caller = $stack[0]; $message = $args[0]; - $log = date('c') . ' - '; + $log = date('c') . ' - ' . $caller['file'] . '[' . $caller['line'] . ']'; if (is_array($message)) { foreach ($message as $key => $val) { @@ -50,7 +55,7 @@ public function __call($name, array $args) $log .= ' ' . $message; } - error_log($log . "\n", 3, $this->_dir . '/' . $name . '.log'); + error_log($log . "\n", 3, $this->_dir . $name . '.log'); } } From d14148c5c8f8e4c33b0adc8cbb7b19a9bc2739d1 Mon Sep 17 00:00:00 2001 From: airylinus Date: Sun, 23 Jun 2013 09:40:17 +0800 Subject: [PATCH 2/2] fix typo --- Helper/Logger.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Helper/Logger.php b/Helper/Logger.php index 7e7d366..8a3f515 100644 --- a/Helper/Logger.php +++ b/Helper/Logger.php @@ -26,7 +26,7 @@ class Logger */ public function __construct($dir) { - if (!in_array(substr($dir, -1) array("/", "\\"))) { + if (!in_array(substr($dir, -1), array("/", "\\"))) { $dir .= DIRECTORY_SEPARATOR; } $this->_dir = $dir;