Shaded munit-diff isn't applicable for Scala Native

[zainab-ali]

This was identified in #207

Using weaver with a version of munit-diff compiled with a different Scala.js version fails with linking errors. This implies that the shading isn't applied to Scala.js.

The shading plugin works on a Java bytecode level by renaming symbols, which is probably the cause.

[Baccata]

Ergh, indeed, forgot about this "minor detail" ...

Our options are basically :

• vendor (ie copy/paste) the munit implementation ourselves
• stop shading the munit implementation

What do you think we should do ?

[zainab-ali]

Actually, I've misdiagnosed the cause. The original issue was for Scala Native, not Scala.js

The shading plugin does appear to work for Scala.js. The published jars contain weaver/internal/shaded/munit/diff/*.sjsir files, and munit-diff isn't listed as a dependency in the Scala.js pom.xml.

This is also true for Scala Native. The publised native jars also contain weaver/internal/shaded/munit/diff/*.nir files, and don't list munit-diff as a dependency.

The munit-diff API or internals haven't changed between versions v1.1.0 and v1.2.0, and fs2-data doesn't pull in munit, so this shouldn't be a problem with dependency conflicts. I'm digging deeper into it.

[zainab-ali]

I've reproduced this with Scala CLI:

scala-cli https://gist.github.com/zainab-ali/fa5793f256d38d9c1615c6cf443c7eed

Unfortunately the linking errors affect everyone using weaver on Scala Native, not just munit users.

The sbt-shading plugin doesn't appear to have any cross platform tests for Native, so I suspect it's not supported properly.

As a workaround, what do you think about removing shading for Native only?

In the long term, we could either:

• Add Native support to the shading plugin
• Vendor the diff implementation

[Baccata]

As a workaround, what do you think about removing shading for Native only?

I certainly think that's acceptable knowing that projects that would use weaver and SN are probably less than 10 at this point in time.