Bug: Missing mapPoint function

[waltsims]

What Happened?

mapPoint seems to be missing from the v1.4.0 release of the k-wave toolbox.

Error messages

NA

How Can We Reproduce?

I didn't run the code with kgrid.nonuniform but the method mapPoint is not listed in the repository.

Operating System

Mac

Release Version

1.4 (Default)

MATLAB Version

9.13.0.2049777 (R2022b)

[btreeby]

Well spotted. The nonuniform grid option has never been officially supported (it’s only implemented in 1D), and currently isn’t supported by tests, which is why I missed it. I’ll take a look at migrating an old non-uniform example into the toolbox.

Is this functionality you make use of?

[waltsims]

Thank you! I am not currently using this functionality, but I stumbled across it when looking to port offGridPoints to k-wave-python, and I wanted to bring it to your attention. 👍

[stellaprins]

@bencox is support for non-uniform grids something that still needs to be implemented in the k-Wave toolbox?

I’ll take a look at migrating an old non-uniform example into the toolbox.

If we do, an example of a non-uniform grid workflow would be helpful.

I've tweaked an example to use a non-uniform grid, set up with help of the setNUGrid method, see here, but not sure whether this is right.

Happy to talk more about it.